634003 - yasm version check broken

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Justin Lebar (not reading bugmail)]

See bug 608423 comment 14.

$ yasm --version | sed -ne "s|.* \([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+\).*|\1|p"
(no output)

I wonder if this works anywhere?  It doesn't work on my Linux box, and it doesn't work on Windows.  Does it even work on Mac?

I think, *maybe*, 

$ yasm --version | sed -ne "s|.* \([0-9]\{1,\}\.[0-9]\{1,\}\.[0-9]\{1,\}\.[0-9]\{1,\}\).*|\1|p"
1.1.0.2352

is right.  It also works with --posix.  Does someone have a Windows and Mac box handy to test on?

Comment 1

[Mitchell Field [:Mitch]]

The former fails and the latter gives expected results with MozillaBuild 1.5.1 on Win7 x64 here.

Comment 2

[Justin Lebar (not reading bugmail)]

Attachment: Patch v1

Comment 3

[Hanspeter Niederstrasser]

On OS X 10.5 with Fink's yasm (there is no system yasm) installed: the first gives no output, the 2nd gives "1.0.1.2326"

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 512207 [details] [diff] [review]
Patch v1

I'm r+ing this as if I can really parse that, but having tested it on all three Tier-1 platforms, I feel ok.

Comment 5

[Justin Lebar (not reading bugmail)]

Yeah, the syntax is really gross.

One of these days, configure will be a Python script, and all will be right with the world.

Comment 6

[Justin Lebar (not reading bugmail)]

Comment on attachment 512207 [details] [diff] [review]
Patch v1

Requesting a2.0.

This is green on try [1], so it shouldn't break the build.  I looked through the logs of the builds and don't see any yasm errors during configure (although, to be fair, I've missed them before).

[1] http://tbpl.mozilla.org/?tree=MozillaTry&rev=0384189a6297

Comment 7

[Justin Lebar (not reading bugmail)]

http://hg.mozilla.org/mozilla-central/rev/39c1bcf89e72

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> See bug 608423 comment 14.

V.Fixed, on my Windows 2000 too.