yasm version check broken

VERIFIED FIXED in mozilla2.0b12

Status

Firefox Build System
General
VERIFIED FIXED
7 years ago
3 months ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: Justin Lebar (not reading bugmail))

Tracking

Trunk
mozilla2.0b12

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
See bug 608423 comment 14.

$ yasm --version | sed -ne "s|.* \([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+\).*|\1|p"
(no output)

I wonder if this works anywhere?  It doesn't work on my Linux box, and it doesn't work on Windows.  Does it even work on Mac?

I think, *maybe*, 

$ yasm --version | sed -ne "s|.* \([0-9]\{1,\}\.[0-9]\{1,\}\.[0-9]\{1,\}\.[0-9]\{1,\}\).*|\1|p"
1.1.0.2352

is right.  It also works with --posix.  Does someone have a Windows and Mac box handy to test on?
The former fails and the latter gives expected results with MozillaBuild 1.5.1 on Win7 x64 here.
(Assignee)

Comment 2

7 years ago
Created attachment 512207 [details] [diff] [review]
Patch v1
Attachment #512207 - Flags: review?(ted.mielczarek)
On OS X 10.5 with Fink's yasm (there is no system yasm) installed: the first gives no output, the 2nd gives "1.0.1.2326"
Comment on attachment 512207 [details] [diff] [review]
Patch v1

I'm r+ing this as if I can really parse that, but having tested it on all three Tier-1 platforms, I feel ok.
Attachment #512207 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → justin.lebar+bug
(Assignee)

Comment 5

7 years ago
Yeah, the syntax is really gross.

One of these days, configure will be a Python script, and all will be right with the world.
(Assignee)

Comment 6

7 years ago
Comment on attachment 512207 [details] [diff] [review]
Patch v1

Requesting a2.0.

This is green on try [1], so it shouldn't break the build.  I looked through the logs of the builds and don't see any yasm errors during configure (although, to be fair, I've missed them before).

[1] http://tbpl.mozilla.org/?tree=MozillaTry&rev=0384189a6297
Attachment #512207 - Flags: approval2.0?

Updated

7 years ago
Attachment #512207 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 7

7 years ago
http://hg.mozilla.org/mozilla-central/rev/39c1bcf89e72
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(In reply to comment #0)
> See bug 608423 comment 14.

V.Fixed, on my Windows 2000 too.
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
Target Milestone: --- → mozilla2.0b12
Version: unspecified → Trunk

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.