634132 - The page flickers/flashes black when scrolling the page while a flash video (on BBC, Engadget, and perhaps other sites) is playing

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[(no longer active)]

STR:

1. Load the page.
2. Play the video.
3. Scroll.

Comment 1

[(no longer active)]

This happens on Persian and English BBC.  I guess it's safe to assume that it happens on all langauges at bbc.com.

<http://www.bbc.co.uk/news/world-middle-east-12447225>

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Is this still a problem after the neutering of bug 591687?

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Joe said he was seeing this on Engadget on Mac; perhaps a more general summary is required?

Comment 4

[(no longer active)]

(In reply to comment #2)
> Is this still a problem after the neutering of bug 591687?

If you mean bug 633826, then yes.  I'm running today's nightly which includes that patch.

(In reply to comment #3)
> Joe said he was seeing this on Engadget on Mac; perhaps a more general summary
> is required?

Done.

Comment 5

[Benjamin Smedberg]

What version of Flash? I don't see any issues with Flash 10.2 on Gecko/20110215

Comment 6

[Joe Drew (not getting mail)]

10.1.102.64

Comment 7

[(no longer active)]

(In reply to comment #6)
> 10.1.102.64

I'm using 10.2.152.26.

Given that Joe is seeing this on an older version of Flash, could this be something which we've recently broken on our side?

Comment 8

[Gordon P. Hemsley [:GPHemsley]]

Just updated to the 2011-02-14 nightly (I'm behind at the moment) and started seeing this on YouTube. The screen only flickers when the Flash content is visible. Once you scroll past it, it has no effect.

I appear to be using version 10.1.102.64 of Flash, as well. (Mac OS X 10.6.6, 64-bit)

Comment 9

[(no longer active)]

Regression range: <http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=51702867d932&tochange=26421a3b68f3>

Which tells me that this is a regression from bug 633826.

Comment 10

[Joe Drew (not getting mail)]

I can reproduce this while playing the video on http://dogs.icanhascheezburger.com/2011/02/21/funny-dog-videos-pug-plays-with-pigeon-friend - since comment 6, I've upgraded to 10.2.152.26.

I'm going to renominate this just because it seems to be fairly widespread. I'm willing to accept blocking-, but this bug isn't rare.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Good god, that's awful - does a local backout of bug 633826 resolve this? Josh, can you take a look?

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Here's some WebM of me reproducing the issue:

http://people.mozilla.org/~beltzner/flash-scroll.webm

I've found that it's not 100% reproducible, but:
 - I can reproduce with the mousewheel and the trackpad
 - if I can't reproduce the first time, reloading the page helps (maybe related to an ad they are serving?)
 - changing smoothscrolling has no effect

And here's my GFX info:

Adapter Description0x22600,0x20400
Vendor ID0000
Device ID0000
Adapter RAM
Adapter Drivers
Driver Version
Driver Date
Direct2D Enabled false
DirectWrite Enabled false
WebGL Renderer NVIDIA Corporation -- NVIDIA GeForce 9400M OpenGL Engine -- 2.1 NVIDIA-1.6.26
GPU Accelerated Windows 1/1 OpenGL

Comment 13

[joren.de.cuyper]

When playing Joe Drew's video, I can't see any flicker, but scrolling on the page while playing the video result in a stuttering scroll movement.

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

So this is Mac only, GL acceleration only?

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Visibly bad behaviour on popular sites --> blocking.

Comment 16

[Joe Drew (not getting mail)]

This is definitely accelerated-only. Can't comment on whether it's Mac-only.

Comment 17

[Marcia Knous [:marcia]]

I wasn't able to reproduce on one of the Win 7 lab machines using Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110222 Firefox/4.0b12pre using Flash Version: 10.1.102.64 or Version: 10.2.152.26.

Comment 18

[Matt Woodrow (:mattwoodrow)]

Bug 633826 was essentially reverted when bug 591687 was completed.

Can anyone reproduce this in the latest nightlies? I can't repro on BBC or icanhascheezburger.com with a 32bit local build.

Flash: 10.2.152.26

Comment 19

[joren.de.cuyper]

As mentioned in comment #13, I can't reproduce the flickering video, but the scroll movement is very stuttering. Not the BBC video. I've used the video mentioned in comment #10.

I've reproduce this with the latest nightly (4.0b12 (22-02-2011)), on a Mac OS X 10.6.6 (MacBook Pro early 2010).
Flash 10.2.152.26.

Comment 20

[Matt Woodrow (:mattwoodrow)]

Looks like this only occurs in debug builds.

Regression range is:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9698ac3f1c61&tochange=51702867d932

Comment 21

[Matt Woodrow (:mattwoodrow)]

Attachment: Fix

Looks like drawing the sending the draw event to the plugin was changing the current GL context. Because it wasn't being changed through our architecture, MOZ_GL_DEBUG wasn't catching it.

Wasn't showing up in debug builds because the DEBUG_GL_ERROR_CHECK(gl()); call includes a MakeCurrent.

The only thing I'm not sure about is how this actually changed with my patch.

Comment 22

[Matt Woodrow (:mattwoodrow)]

Actually, I see it. MacIOSurfaceImageOGL::SetData changes the current context to the global shared context. In debug mode (with MOZ_GL_DEBUG) we would abort instantly when using the wrong context, but DEBUG_GL_ERROR_CHECK fixes the situation before it's used incorrectly.

Maybe we should remove all the DEBUG_GL_ERROR_CHECK code since it's been superseded and is now actually reducing the effectiveness of our (bjacob's) GL debug layer?

Comment 23

[Robert O'Callahan (:roc) (email my personal email if necessary)]

heroic!

Comment 24

[Benoit Jacob [:bjacob] (mostly away)]

I agree that we should remove DEBUG_GL_ERROR_CHECK and GLDebugPrintError.

If we want this feature, something similar is provided by MOZ_GL_DEBUG anyway. If one wants to trace GL errors, one can either use MOZ_GL_DEBUG_ABORT_ON_ERROR or just MOZ_GL_DEBUG with a breakpoint set in AfterGLCall().

Comment 25

[Joe Drew (not getting mail)]

Comment on attachment 514433 [details] [diff] [review]
Fix

Add a comment to say that the callback can reset the current GL context and check this mofo in

Comment 26

[Matt Woodrow (:mattwoodrow)]

Attachment: Patch for landing

Comment 27

[Matt Woodrow (:mattwoodrow)]

Landed as http://hg.mozilla.org/mozilla-central/rev/1d56b96c92a5

Comment 28

[Maniac Vlad Florin (:vladmaniac)]

Verified with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0) Gecko/20100101 Firefox/4.0 

Flash Version: 10.2.152.26

Comment 29

[dbuc]

I've been experiencing this for the last couple weeks on Windows 8.1 - not sure if something regressed or it's a new bug causing the same outcome.