Closed Bug 634295 Opened 9 years ago Closed 9 years ago

'worker.tab' API needs to be documented

Categories

(Add-on SDK Graveyard :: Documentation, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wbamberg, Assigned: wbamberg)

Details

Attachments

(1 file)

The 'worker.tab' API introduced in bug 621903 needs to be documented, probably by extending the page-mod docs.
Assignee: nobody → wbamberg
OS: Mac OS X → All
Initially I was going to document worker.tab in terms of this request: http://groups.google.com/group/mozilla-labs-jetpack/browse_thread/thread/bfff7456a53bae1?hl=en&pli=1. But then I realized that actually tab.attach seems to provide a better way to do that.

So I documented both, but the example for worker.tab isn't very useful-looking.
Attachment #518247 - Flags: review?(myk)
Attachment #518247 - Flags: feedback?
Comment on attachment 518247 [details] [diff] [review]
Add some documentation for worker.tab

Looks good, r=myk!

(In reply to comment #1)
> So I documented both, but the example for worker.tab isn't very useful-looking.

I think it's fine.  But let's keep our eyes open for uses of the property that we can convert into a more real-world example!
Attachment #518247 - Flags: review?(myk)
Attachment #518247 - Flags: review+
Attachment #518247 - Flags: feedback?
Fixed by: https://github.com/mozilla/addon-sdk/commit/58e0f732495f382e542fe5f7389566afc0785fc9
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.