634418 - The ldappool needs to be purged on credentials changes

Status: VERIFIED FIXED

(Cloud Services :: Server: Core, defect)

Description

[Tarek Ziadé (:tarek)]

ldapsql needs to purge any active connector in the pool when these APIs are called:

- delete_user
- update_password

I'll add a purge(bind) in the pool, and call it in these apis + tests

Comment 1

[Tarek Ziadé (:tarek)]

extra note: we need to protect the purge from concurrent accesses in case a syncing is going on.

Comment 2

[:Atoll]

Adding Pete since he is wise in the ways of LDAP

Comment 3

[Tarek Ziadé (:tarek)]

Attachment: Purges the pool

Fixes the bug and also clean up the ldap tests: the fake connectors are now also pooled so we have a similar behavior in the tests

Comment 4

[Tarek Ziadé (:tarek)]

Added in http://hg.mozilla.org/services/server-core/rev/09e09069478c

Comment 5

[Tarek Ziadé (:tarek)]

Sorry, forgot my latest comment that was for another bug :)

Comment 6

[Tarek Ziadé (:tarek)]

Commited in http://hg.mozilla.org/services/server-core/rev/db4f9400966d

Comment 7

[Tracy Walker [:tracy]]

verified, no longer able to change PW, then log in with original. Only login with new.

Comment 8

[:Atoll]

(In reply to comment #7)
> verified, no longer able to change PW, then log in with original. Only login
> with new.

Missing from this bug is a note that ldappool is now disabled by default.  If the above "verified" note applies to the staging or prod account portal, you may wish to coordinate with ops to repeat the tests with connection pooling enabled, so as to test the new ldappool code.