634446 - AVMFEATURE_INDIRECT_NATIVE_THUNKS does not pay for itself

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Steven Johnson]

Disabling this provides better compile-time type checking at a modest cost: a Mac x64 build increased by 57k (~0.4% increase in size). IMHO we should remove it entirely and use solely direct thunks.

Comment 1

[Steven Johnson]

Attachment: Patch

Remove the option for indirect thunks entirely.

Comment 2

[Rick Reitmaier]

Comment on attachment 512642 [details] [diff] [review]
Patch

Seems fine as long as this is not being used elsewhere (e.g. aot) and rubber-stamping the nativegen.py changes.

Comment 3

[Edwin Smith]

When is this currently being enabled/disabled by player?

Not for or against, but whenever bug 588750 gets around to landing, indirect thunks may return in a different form, only used along slow paths.  Its on the back burner for now.

Comment 4

[Steven Johnson]

Currently, avmshell uses indirect in nondebugger, direct in debugger; Flash/AIR use indirect at all times.

Comment 5

[Steven Johnson]

BTW, the motivation for landing this is mainly that it will streamline some of the ANI work, as well as add some long-overdue error checking (attempting to enable this in Flash turned up a halfdozen mismatches)

Comment 6

[Edwin Smith]

Comment on attachment 512642 [details] [diff] [review]
Patch

This will make jit-generating thunks that much easier as well.

Comment 7

[Steven Johnson]

Some of the "wrong" Flash code will be easier to fix once 634635 lands, adding that as a dependency before landing this

Comment 8

[Steven Johnson]

Removing dependency, found a simple workaround

Comment 9

[Steven Johnson]

TR 5936:3c2961b09980

Comment 10

[Tamarin Bot]

changeset: 5937:860aec924bc2
user:      Steven Johnson <[e-mail]>
summary:   Bug 634446 followup: tweaks for AOT (probably more to follow) (r=me)

http://hg.mozilla.org/tamarin-redux/rev/860aec924bc2

Comment 11

[Tamarin Bot]

changeset: 5941:8deda767cb88
user:      Steven Johnson <[e-mail]>
summary:   Bug 634446 followup part 2: more AOT fixes (r=alexmac)

http://hg.mozilla.org/tamarin-redux/rev/8deda767cb88