AVMFEATURE_INDIRECT_NATIVE_THUNKS does not pay for itself

RESOLVED FIXED

Status

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: stejohns, Assigned: stejohns)

Tracking

Details

Attachments

(1 attachment)

Disabling this provides better compile-time type checking at a modest cost: a Mac x64 build increased by 57k (~0.4% increase in size). IMHO we should remove it entirely and use solely direct thunks.
Posted patch PatchSplinter Review
Remove the option for indirect thunks entirely.
Assignee: nobody → stejohns
Attachment #512642 - Flags: superreview?(edwsmith)
Attachment #512642 - Flags: review?(rreitmai)
Comment on attachment 512642 [details] [diff] [review]
Patch

Seems fine as long as this is not being used elsewhere (e.g. aot) and rubber-stamping the nativegen.py changes.
Attachment #512642 - Flags: review?(rreitmai) → review+
When is this currently being enabled/disabled by player?

Not for or against, but whenever bug 588750 gets around to landing, indirect thunks may return in a different form, only used along slow paths.  Its on the back burner for now.
Currently, avmshell uses indirect in nondebugger, direct in debugger; Flash/AIR use indirect at all times.
BTW, the motivation for landing this is mainly that it will streamline some of the ANI work, as well as add some long-overdue error checking (attempting to enable this in Flash turned up a halfdozen mismatches)
Comment on attachment 512642 [details] [diff] [review]
Patch

This will make jit-generating thunks that much easier as well.
Attachment #512642 - Flags: superreview?(edwsmith) → superreview+
Some of the "wrong" Flash code will be easier to fix once 634635 lands, adding that as a dependency before landing this
Depends on: 634635
Removing dependency, found a simple workaround
No longer depends on: 634635
TR 5936:3c2961b09980
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
changeset: 5937:860aec924bc2
user:      Steven Johnson <stejohns@adobe.com>
summary:   Bug 634446 followup: tweaks for AOT (probably more to follow) (r=me)

http://hg.mozilla.org/tamarin-redux/rev/860aec924bc2
changeset: 5941:8deda767cb88
user:      Steven Johnson <stejohns@adobe.com>
summary:   Bug 634446 followup part 2: more AOT fixes (r=alexmac)

http://hg.mozilla.org/tamarin-redux/rev/8deda767cb88
You need to log in before you can comment on or make changes to this bug.