Closed Bug 634549 Opened 13 years ago Closed 13 years ago

Cocoa's progress bar widget should use HTML progress element's values

Categories

(Core :: Widget: Cocoa, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla6

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch Patch v1 (obsolete) — Splinter Review
Cocoa's progress bar widget is the only widget that actually draw itself the bar so it needs the current value and the max value. For the moment, the code doing that is assuming that the element is a XUL progressmeter element.

This patch makes it work with an HTML progress element. There is a [dirty] hack that consist of multiplying the float value we get because Cocoa's widget takes only integers for value and max.
Attachment #512754 - Flags: review?(mstange)
Attachment #512754 - Flags: review?(roc)
Whiteboard: [needs review]
Depends on: 514437
How about this: Make GetProgressValue and GetProgressMaxValue return a float, and then in DrawProgress always set tdi.max to PR_INT32_MAX and do some calculations to get the correct value.
Then we always use the best precision we can get and don't have to choose an arbitrary number.
Attached patch Patch v1.1 (obsolete) — Splinter Review
Should be better now even if I spent half an hour before understanding why PR_INT32_MAX*1 gives PR_INT32_MIN ;)
Attachment #512754 - Attachment is obsolete: true
Attachment #512790 - Flags: review?(mstange)
Attachment #512754 - Flags: review?(roc)
Attachment #512754 - Flags: review?(mstange)
Attachment #512790 - Flags: review?(roc)
Comment on attachment 512790 [details] [diff] [review]
Patch v1.1

Oh no :(

Maybe roc has a better idea how to make this presentable.
Attachment #512790 - Flags: review?(mstange) → review+
Attached patch Patch v1.2Splinter Review
r=mstange

The HTML progress element is now using doubles which is fixing the rounding issue. Markus, do you still want Roc's review?
Attachment #512790 - Attachment is obsolete: true
Attachment #515604 - Flags: review?(roc)
Attachment #512790 - Flags: review?(roc)
Whiteboard: [needs review] → [ready to land][waits for dependencies]
Blocks: 634551
Pushed:
http://hg.mozilla.org/mozilla-central/rev/94dc6447f102
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [ready to land][waits for dependencies]
Target Milestone: --- → mozilla6
Depends on: 655860
Backed out in http://hg.mozilla.org/mozilla-central/rev/dd9ba28d2bd9 to resolve bug 655860.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The regression wasn't caused by these patches. Re-landed:
http://hg.mozilla.org/mozilla-central/rev/5b69bdf44737
Status: REOPENED → RESOLVED
Closed: 13 years ago13 years ago
Resolution: --- → FIXED
No longer depends on: 655860
You need to log in before you can comment on or make changes to this bug.