634596 - On Windows, use hardlinks when --enable-chrome-format=symlink is specified

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: patch v1

--enable-chrome-format=symlink is really useful when you're editing JS or xul files. We can't do symlinks on Windows, even Vista/7 (mainly because non-admins don't have the privilege to do it, and even if an admin is explicitly granted the privilege, UAC strips it away). However we can create hardlinks instead, and that'll work for the use case we want to support here.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 512803 [details] [diff] [review]
patch v1

I bet you'll probably break some goofy platform like OS/2 with this, but they would have to explicitly enable this, so maybe it doesn't matter.

Can you add a test for this to http://mxr.mozilla.org/mozilla-central/source/config/tests/unit-JarMaker.py ?

Comment 2

[Rain [:rain1] (inactive)]

Attachment: tests v1

This passes locally, and I've pushed to try to make sure it passes on Mac/Linux/FAT32 as well.

Comment 3

[Rain [:rain1] (inactive)]

Attachment: tests v2

That wouldn't have, but this did.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 515755 [details] [diff] [review]
tests v2

Thanks a lot for taking the time to write a test!

Comment 5

[Rain [:rain1] (inactive)]

https://hg.mozilla.org/projects/build-system/rev/77722540b29f
https://hg.mozilla.org/projects/build-system/rev/1b92ec727deb

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/77722540b29f
http://hg.mozilla.org/mozilla-central/rev/1b92ec727deb