On Windows, use hardlinks when --enable-chrome-format=symlink is specified

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: sid0, Assigned: sid0)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs)

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 512803 [details] [diff] [review]
patch v1

--enable-chrome-format=symlink is really useful when you're editing JS or xul files. We can't do symlinks on Windows, even Vista/7 (mainly because non-admins don't have the privilege to do it, and even if an admin is explicitly granted the privilege, UAC strips it away). However we can create hardlinks instead, and that'll work for the use case we want to support here.
Attachment #512803 - Flags: review?(ted.mielczarek)
Comment on attachment 512803 [details] [diff] [review]
patch v1

I bet you'll probably break some goofy platform like OS/2 with this, but they would have to explicitly enable this, so maybe it doesn't matter.

Can you add a test for this to http://mxr.mozilla.org/mozilla-central/source/config/tests/unit-JarMaker.py ?
Attachment #512803 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 2

7 years ago
Created attachment 515697 [details] [diff] [review]
tests v1

This passes locally, and I've pushed to try to make sure it passes on Mac/Linux/FAT32 as well.
(Assignee)

Comment 3

7 years ago
Created attachment 515755 [details] [diff] [review]
tests v2

That wouldn't have, but this did.
Attachment #515697 - Attachment is obsolete: true
Attachment #515755 - Flags: review?(ted.mielczarek)
Comment on attachment 515755 [details] [diff] [review]
tests v2

Thanks a lot for taking the time to write a test!
Attachment #515755 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 5

7 years ago
https://hg.mozilla.org/projects/build-system/rev/77722540b29f
https://hg.mozilla.org/projects/build-system/rev/1b92ec727deb
Whiteboard: fixed-in-bs
http://hg.mozilla.org/mozilla-central/rev/77722540b29f
http://hg.mozilla.org/mozilla-central/rev/1b92ec727deb
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.