Closed Bug 634596 Opened 9 years ago Closed 9 years ago

On Windows, use hardlinks when --enable-chrome-format=symlink is specified

Categories

(Firefox Build System :: General, defect)

x86
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rain1, Assigned: rain1)

Details

(Whiteboard: fixed-in-bs)

Attachments

(2 files, 1 obsolete file)

Attached patch patch v1Splinter Review
--enable-chrome-format=symlink is really useful when you're editing JS or xul files. We can't do symlinks on Windows, even Vista/7 (mainly because non-admins don't have the privilege to do it, and even if an admin is explicitly granted the privilege, UAC strips it away). However we can create hardlinks instead, and that'll work for the use case we want to support here.
Attachment #512803 - Flags: review?(ted.mielczarek)
Comment on attachment 512803 [details] [diff] [review]
patch v1

I bet you'll probably break some goofy platform like OS/2 with this, but they would have to explicitly enable this, so maybe it doesn't matter.

Can you add a test for this to http://mxr.mozilla.org/mozilla-central/source/config/tests/unit-JarMaker.py ?
Attachment #512803 - Flags: review?(ted.mielczarek) → review+
Attached patch tests v1 (obsolete) — Splinter Review
This passes locally, and I've pushed to try to make sure it passes on Mac/Linux/FAT32 as well.
Attached patch tests v2Splinter Review
That wouldn't have, but this did.
Attachment #515697 - Attachment is obsolete: true
Attachment #515755 - Flags: review?(ted.mielczarek)
Comment on attachment 515755 [details] [diff] [review]
tests v2

Thanks a lot for taking the time to write a test!
Attachment #515755 - Flags: review?(ted.mielczarek) → review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.