Closed
Bug 634609
Opened 14 years ago
Closed 14 years ago
Fix GetNativeStackBaseImpl() on OpenBSD
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: gaston, Assigned: gaston)
References
Details
Attachments
(2 files)
957 bytes,
patch
|
gal
:
review+
joe
:
approval2.0-
|
Details | Diff | Splinter Review |
653 bytes,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Midori/0.3 (X11; OpenBSD; U; fr-fr) WebKit/531.2+
Build Identifier:
As of now, js fails to build on OpenBSD because either pthread_attr_get_np() or pthread_getattr_np() don't exist.
pthread_attr_init() + pthread_attr_getstack() won't work on OpenBSD, so we have to use pthread_stackseg_np() instead.
Reproducible: Always
Assignee | ||
Comment 1•14 years ago
|
||
First proposition for a patch, minimizing the diff.
Ideally, the codepath for OpenBSD wouldn't need pthread_attr_t/pthread_attr_init/pthread_attr_destroy, so maybe it should be inside its own #ifdef block like macos code.
We might still need the last part of the function changing what's returned depending on JS_STACK_GROWTH_DIRECTION (though we don't build mozilla on hppa yet)
Attachment #512815 -
Flags: review?(brendan)
Comment 2•14 years ago
|
||
Comment on attachment 512815 [details] [diff] [review]
use pthread_stackseg_np() on OpenBSD
Stealing. NPOTB, so no risk but even than approval might not come until after FF4 branched.
Attachment #512815 -
Flags: review?(brendan)
Attachment #512815 -
Flags: review+
Attachment #512815 -
Flags: approval2.0?
Updated•14 years ago
|
Assignee: general → landry
Updated•14 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Updated•14 years ago
|
Attachment #512815 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 3•14 years ago
|
||
What's the procedure to get that commited now that there's r+ and a2.0+ ?
Should i do another patch putting the OpenBSD code inside its own #ifdef block for the sake of readability ?
Comment 4•14 years ago
|
||
Just land it on the TM tree if you have commit access, or find someone who has.
Keywords: checkin-needed
Comment 5•14 years ago
|
||
Comment on attachment 512815 [details] [diff] [review]
use pthread_stackseg_np() on OpenBSD
Sorry, too late for 2.0.
Attachment #512815 -
Flags: approval2.0+ → approval2.0-
Comment 6•14 years ago
|
||
Keywords: checkin-needed
Whiteboard: fixed-in-tracemonkey
Comment 7•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•14 years ago
|
Blocks: openbsdmeta
Assignee | ||
Comment 8•14 years ago
|
||
Duh!. pthread_np.h also needs to be included on OpenBSD for pthread_stackseg_np() to be defined... sorry i missed that one.
Attachment #527210 -
Flags: review?(gal)
Updated•14 years ago
|
Attachment #527210 -
Flags: review?(gal) → review+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Comment 10•14 years ago
|
||
Pushed to cedar.
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: fixed-in-tracemonkey → [fixed in cedar]
Version: unspecified → Trunk
Comment 11•14 years ago
|
||
Pushed:
http://hg.mozilla.org/mozilla-central/rev/6588e8a0c8c5
(oups, I didn't meant to mark the bug as fixed before...)
Whiteboard: [fixed in cedar]
Target Milestone: --- → mozilla6
You need to log in
before you can comment on or make changes to this bug.
Description
•