634734 - Fennec ASSERTION: mFUnitsConvFactor not valid: 'mFUnitsConvFactor > 0.0f

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Doug Turner (:dougt)]

When loading pages in fennec, I see lots of these assertions

Comment 1

[Karl Tomlinson (:karlt)]

mFUnitsConvFactor should be set before using mHarfBuzzShaper.
It need only be done once.
gfxPangoFont does that here:
http://hg.mozilla.org/mozilla-central/annotate/64d579f7746b/gfx/thebes/gfxPangoFonts.cpp#l2117
gfxFT2Font should do something similar.
There may be advantage in delaying locking the face till InitTextRun if the FT_Face does not have the right size already set at time of gfxFT2Font construction.

Comment 2

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 3

[Karl Tomlinson (:karlt)]

Comment on attachment 512958 [details] [diff] [review]
patch v.1

>     if (gfxPlatform::GetPlatform()->UseHarfBuzzLevel() >=
>         gfxUnicodeProperties::ScriptShapingLevel(aRunScript))
>     {
>+        if (!mHarfBuzzShaper) 
>+        {

"{" should be at the end of the "(!mHarfBuzzShaper)" line.

(The "{" at the start of the line above is special because of the multi-line condition and 4-space indent.)

Comment 4

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/9eacc33dd8f2
http://hg.mozilla.org/mozilla-central/rev/039b9f95368f (whitespace)