Closed Bug 634773 Opened 12 years ago Closed 11 years ago
CSPUtils incorrectly compares two CSPSource
Lists - *.equals('none') returns true
CSPSourceList.prototype.equals compares two source lists by doing two checks: 1. their length is equal 2. each of the items in the sorted list of sources is equal This causes * and 'none' to be considered equal because they both have an empty internal source list. Fixing this bug is trivial. It is, however, hiding a bug in content/base/test/unit/test_bug558431.js. Only that test has the bug, NOT the feature it's testing, so we don't need to worry about fixing this for Firefox 4. I'll file a follow-up bug to fix that test.
unbitrotted trivial fix and added test cases. jst: this is literally a three line fix (two that matter), touching only CSPUtils.jsm. Can you take a quick look?
Pushed to inbound. https://hg.mozilla.org/integration/mozilla-inbound/rev/829e55e4ff61
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla15
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.