Closed
Bug 634865
Opened 13 years ago
Closed 13 years ago
Non libxul build bustage: undefined reference to xpc_UnmarkGrayObjectRecursive
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla2.0b12
People
(Reporter: mounir, Assigned: peterv)
References
Details
Attachments
(1 file, 2 obsolete files)
|
2.01 KB,
patch
|
jst
:
review+
jst
:
approval2.0+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
This reverts http://hg.mozilla.org/mozilla-central/diff/b43290ec9366/modules/plugin/base/src/nsJSNPRuntime.cpp which sucks a little, cause it'll be slower but oh well. GetWrappedNativeOfNativeObject morphs slim wrappers, but plugin-owning elements never have slim wrappers because of the complicated proto chain anyway.
|
|
Assignee | |
Comment 2•13 years ago
|
||
Hmm, probably need to null-check obj.
Attachment #513085 -
Attachment is obsolete: true
Attachment #513088 -
Flags: review?(jst)
Attachment #513085 -
Flags: review?(jst)
|
|
Assignee | |
Comment 3•13 years ago
|
||
qref'ing helps!
Attachment #513088 -
Attachment is obsolete: true
Attachment #513090 -
Flags: review?(jst)
Attachment #513088 -
Flags: review?(jst)
|
||
Updated•13 years ago
|
Attachment #513090 -
Flags: review?(jst)
Attachment #513090 -
Flags: review+
Attachment #513090 -
Flags: approval2.0+
|
Reporter | |
Comment 4•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/7aa1f8091ae9 Thanks for this patch Peter :)
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
OS: Linux → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
You need to log in
before you can comment on or make changes to this bug.
Description
•