635010 - new Error(undefined).hasOwnProperty("message") should be false

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

We fail http://test262.ecmascript.org/ test S15.11.1.1_A1_T1.

Basically
  assertEq("message" in new Error(undefined), false);

I checked the spec. The test is right. We're wrong. 
http://people.mozilla.org/~jorendorff/es5.html#sec-15.11.1.1

Comment 1

[Jason Orendorff [:jorendorff]]

S15.11.1.1_A1_T1 tests `Error(undefined)`.
S15.11.2.1_A1_T1 tests `new Error(undefined)`.

We fail both for the same reason.

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Don't create the message property, if it would be undefined

Comment 3

[Tom S. (please needinfo tschuster)]

Attachment: v2 fixed bug + test

Fixed bug regarding new Error(undefined), and added some test.

Comment 4

[Jason Orendorff [:jorendorff]]

Comment on attachment 517444 [details] [diff] [review]
v2 fixed bug + test

Thanks for the patch. I applied it... but it doesn't seem to fix the bug!

  js> assertEq("message" in new Error(undefined), false);
  typein:3: Error: Assertion failed: got true, expected false
  js> assertEq("message" in new Error(), false);
  typein:4: Error: Assertion failed: got true, expected false

Am I doing something wrong?

Note that tests under js/src/tests need to end with a line like:
  reportCompare(0, 0, 'ok');
and the test has to be added to the jstests.list file in the same directory.

Comment 5

[Tom S. (please needinfo tschuster)]

Attachment: v3 fixed tests

Oh sorry, forgot to mention this. The right test is actually, different, i checked test262, and they use this, too. I have no idea where the "in" came from.
 (new Error(undefined)).hasOwnProperty('message') => false
The "in" test makes no sense, because Error.prototype has an message property with an empty string as value.

My last patch is already a little while back, so i am already forgetting things, bad ;)

Comment 6

[Jason Orendorff [:jorendorff]]

Comment on attachment 517745 [details] [diff] [review]
v3 fixed tests

That makes sense! Nice work.

Comment 7

[Jason Orendorff [:jorendorff]]

http://hg.mozilla.org/tracemonkey/rev/2a7515434a1d

Comment 8

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/2a7515434a1d