635164 - "Assertion failure: userbuf.base <= tokptr && tokptr <= userbuf.limit,"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: stack

Function("function(){};break\n")()

asserts xpcshell on TM changeset 2d44fc834071 without -m nor -j at Assertion failure: userbuf.base <= tokptr && tokptr <= userbuf.limit, tested on 64-bit Mac and Linux.

Nominating blocking2.0? because this shows up very often on fuzzers.

Not the smallest regression window: It didn't used to occur on changeset db8be4e3f373

http://hg.mozilla.org/tracemonkey/pushloghtml?fromchange=db8be4e3f373&tochange=2d44fc834071

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Actually I've a testcase that asserts on 32-bit debug js shells too. Stay tuned.

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #1)
> Actually I've a testcase that asserts on 32-bit debug js shells too. Stay
> tuned.

Reflect.parse("<\n")

asserts js debug shells similarly.

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   62719:2d44fc834071
tag:         tip
user:        Nicholas Nethercote
date:        Thu Feb 17 19:02:48 2011 -0800
summary:     Bug 634444 - Errors in long lines cause memory spikes when a console is in use.  r=brendan, a=blocking.

Fixed by follow-up fix:

http://hg.mozilla.org/tracemonkey/rev/0d4b01278890

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Don't think we'd block, but glad it's fixed and a=beltzner for merging this across.

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

This bug should be updated when bug 634444 is updated / fixed after Fx 4.

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #4)
> This bug should be updated when bug 634444 is updated / fixed after Fx 4.

But perhaps this bug should be resolved somehow since bug 634444 has been backed out..

Fixed by backout of bug 634444.