635209 - startup Crash [@ nsTreeBodyFrame::ScrollInternal(nsTreeBodyFrame::ScrollParts const&, int) ]

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Carsten Book [:Tomcat]]

Top 22 Topcrash for Firefox 4.0b12pre - https://crash-stats.mozilla.com/report/list?signature=nsTreeBodyFrame%3A%3AScrollInternal%28nsTreeBodyFrame%3A%3AScrollParts%20const%26%2C%20int%29

seems to be a startup crash on windows so far


Crashing Thread
Frame 	Module 	Signature [Expand] 	Source
0 	xul.dll 	nsTreeBodyFrame::ScrollInternal 	layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp:4093
1 	xul.dll 	nsTreeBodyFrame::ScrollToRow 	layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp:4040
2 	xul.dll 	nsTreeBodyFrame::EnsureView 	layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp:399
3 	xul.dll 	nsTreeBodyFrame::ReflowFinished 	layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp:430
4 	xul.dll 	PresShell::HandlePostedReflowCallbacks 	layout/base/nsPresShell.cpp:4754
5 	xul.dll 	PresShell::ProcessReflowCommands 	layout/base/nsPresShell.cpp:8014
6 	xul.dll 	PresShell::FlushPendingNotifications 	layout/base/nsPresShell.cpp:4901
7 	xul.dll 	nsRefreshDriver::Notify 	layout/base/nsRefreshDriver.cpp:326
8 	xul.dll 	nsTimerImpl::Fire 	xpcom/threads/nsTimerImpl.cpp:428
9 	xul.dll 	nsTimerEvent::Run 	xpcom/threads/nsTimerImpl.cpp:517
10 	xul.dll 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:633
11 	xul.dll 	NS_ProcessPendingEvents_P 	obj-firefox/xpcom/build/nsThreadUtils.cpp:200
12 	xul.dll 	nsWindow::DispatchPendingEvents 	widget/src/windows/nsWindow.cpp:3904
13 	xul.dll 	nsWindow::ProcessMessage 	widget/src/windows/nsWindow.cpp:5207
14 	xul.dll 	nsWindow::WindowProcInternal 	widget/src/windows/nsWindow.cpp:4580
15 	xul.dll 	CallWindowProcCrashProtected 	xpcom/base/nsCrashOnException.cpp:75
16 		@0x9715e3a5 	
17 	xul.dll 	CallWindowProcCrashProtected 	xpcom/base/nsCrashOnException.cpp:75
18 	xul.dll 	xul.dll@0x35667d 	
19 	xul.dll 	nsWindow::WindowProc 	widget/src/windows/nsWindow.cpp:4524
20 	xul.dll 	xul.dll@0x13a73f 	
21 	user32.dll 	InternalCallWinProc 	
22 	xul.dll 	CallWindowProcCrashProtected 	xpcom/base/nsCrashOnException.cpp:75
23 	xul.dll 	CallWindowProcCrashProtected 	xpcom/base/nsCrashOnException.cpp:75
24 	user32.dll 	UserCallWinProcCheckWow 	
25 	xul.dll 	CallWindowProcCrashProtected 	xpcom/base/nsCrashOnException.cpp:75
26 	user32.dll 	StringDuplicateW 	
27 	user32.dll 	UserCallWinProcCheckWow 	
28 	user32.dll 	DispatchMessageWorker 	
29 	xul.dll 	CallWindowProcCrashProtected 	xpcom/base/nsCrashOnException.cpp:75
30 	user32.dll 	GetShellWindow 	
31 	user32.dll 	NtUserPeekMessage 	
32 	user32.dll 	StringDuplicateW

Comment 1

[chris hofmann]

tomcat,  put a note in the bugs when you see the pattern that make the bugs all look look like duplicates of the same report.

In this case all the reports are within 10:37 - 14:03  on the same day (feb 16) and on the same build, then we haven't seen any reports since. 

correlation to time of day -- hourly frequency of reports
   6 2011021610
  24 2011021611
   3 2011021612
   4 2011021613
   4 2011021614

they also have the same os ver,  Windows NT5.1.2600 Service Pack 3, 

all are 2 or 3 second since last crash, 

and looking deeper you can see they are all the same URL jar:file:///C:/Arquivos%20de%20programas/Minefield/omni.jar!/chrome/browser/content/browser/aboutSessionRestore.xhtml

also add the bug as a dependency to Bug 579136

Josh Berkus is working on a system to flag these automatically and we need some test cases for the detection algorithm.

Comment 2

[Wayne Mery (:wsmwk)]

nsTreeBodyFrame::InvalidateScrollbars(nsTreeBodyFrame::ScrollParts const&, nsWeakFrame&)  is also a startup crash

Comment 3

[Wayne Mery (:wsmwk)]

1 TB user crashing in past 2 months. Not worth keeping open 

But FWIW bp-c787c451-20a3-4f4e-a49d-e2ccb2130516

0	xul.dll	nsTreeBodyFrame::ScrollInternal	layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp:4078
1	xul.dll	nsTreeBodyFrame::ScrollToRow	layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp:4021
2	xul.dll	nsTreeBodyFrame::EnsureView	layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp:367
3	xul.dll	nsTreeBodyFrame::ReflowFinished	layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp:398
4	xul.dll	PresShell::HandlePostedReflowCallbacks	layout/base/nsPresShell.cpp:3734
5	xul.dll	PresShell::DidDoReflow	layout/base/nsPresShell.cpp:7322
6	xul.dll	PresShell::ProcessReflowCommands	layout/base/nsPresShell.cpp:7626 

ehsan@108463 4073nsTreeBodyFrame::ScrollInternal(const ScrollParts& aParts, int32_t aRow)
hg@1 4074 {
hg@1 4075 if (!mView)
hg@1 4076 return NS_OK;
hg@1 4077 
ehsan@108463 4078 int32_t delta = aRow - mTopRowIndex;