635251 - Don't call GC or CC unexpectedly during shutdown.

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

In a tryserver run I got Assertion failure: !cx->thread->data.conservativeGC.requestThreshold, at ../../../../../js/src/xpconnect/src/nsXPConnect.cpp:402
and before that there is 
WARNING: Failed to create timer: file ../../../dom/base/nsJSEnvironment.cpp, line 3445
WARNING: Failed to create timer: file ../../../dom/base/nsJSEnvironment.cpp, line 3407

We could just not call GC/CC in those cases, I think.

Comment 1

[Andreas Gal :gal]

Comment on attachment 513464 [details] [diff] [review]
patch

Kinda unlikely that the timer fails anyway.

Comment 2

[Andreas Gal :gal]

http://hg.mozilla.org/tracemonkey/rev/8ba032375d53

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/1863cc5e27a6

Comment 4

[Nochum Sossonko [:Natch]]

Does this mean that if CallCreateInstance OOMs we won't garbage/cycle collect to free up potential dead memory?

Comment 5

[Nochum Sossonko [:Natch]]

Unless of course it's infallible...

Comment 6

[Andreas Gal :gal]

Driving the browser close to the OOM boundary is pointless. We have to manage our working set and make sure we don't get close to this point in the first place.

Comment 7

[Nochum Sossonko [:Natch]]

(In reply to comment #6)
> Driving the browser close to the OOM boundary is pointless. We have to manage
> our working set and make sure we don't get close to this point in the first
> place.

Well then maybe their should be an upper limit of allowed memory usage before the browser disables new tab/window creation etc. Otherwise, this is a legitimate concern, e.g. if someone opens a very memory-intensive page (or set of pages) and runs out of memory. I don't know the code involved, but it does seem like the timer is created once and reused so this may be a total non-issue, I can't comment for sure on that though.

Comment 8

[Andreas Gal :gal]

There is a million ways to push FF into OOM unfortunately. In the end only a rendering process will save us.