635293 - ANI: general cleanup and refactoring of nativegen.py

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, enhancement)

Description

[Steven Johnson]

Attachment: Patch

This is a major cleanup and restructuring, not quite tantamount to a rewrite, that will make some of the other ANI work a lot simpler to drop in; it also makes the existing output structure a little less hacky. 

I tried doing this in small blobs but in the end I'm submitted this as a giant blob; reviewing the diffs will likely prove to be not-useful, so I'd suggest comparing the output to convince yourself it's essentially the same (though the new output is much more rigorous about outputting fully-namespaced code).

Comment 1

[Rick Reitmaier]

Comment on attachment 513502 [details] [diff] [review]
Patch

I'll trust you on the correctness, but a quick glance at diffs in output convinced me that this is general goodness.

Comment 2

[Tamarin Bot]

changeset: 5947:787b436ba049
user:      Steven Johnson <[e-mail]>
summary:   Bug 635293 - ANI: general cleanup and refactoring of nativegen.py (r=rreitmai)

http://hg.mozilla.org/tamarin-redux/rev/787b436ba049

Comment 3

[Tamarin Bot]

changeset: 5966:e9667482eca8
user:      Steven Johnson <[e-mail]>
summary:   Bug 635293 followup: instancebase_name needed to be converted back from component form to string form (r=stejohns)

http://hg.mozilla.org/tamarin-redux/rev/e9667482eca8

Comment 4

[Steven Johnson]

submitted long ago, finally marking fixed