Closed Bug 635418 Opened 9 years ago Closed 9 years ago

TabShow & TabHide should cause saveStateDelayed

Categories

(Firefox :: Session Restore, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 4.0
Tracking Status
blocking2.0 --- -

People

(Reporter: zpao, Assigned: zpao)

Details

Attachments

(1 file)

Uhh, it apparently doesn't. So if you enter tab view, move things around and even return back to normal view, we won't save the visible state if you crash.

Not really sure how we got to this point like that...
Should this block, at least final, for the state loss?
I *really* don't want to make more blockers, but probably. So soft block final is my vote. Without tests, this will only be the addition of 2 lines of code (actually the same line, twice).
blocking2.0: --- → ?
Won't block, but I will watch like a goddamned hawk for the approval request and agree that this is worth your time, zpao!
blocking2.0: ? → -
Assignee: nobody → paul
Attached patch Patch v0.1Splinter Review
Ok, I added a little more than 2 lines so that we wouldn't have to get the window from the tab after that's already been done.
Attachment #514271 - Flags: review?(dietrich)
Comment on attachment 514271 [details] [diff] [review]
Patch v0.1

r+a=me for final. Please borrow Beltzner's hawk glasses when this lands, to watch the tree with.
Attachment #514271 - Flags: review?(dietrich)
Attachment #514271 - Flags: review+
Attachment #514271 - Flags: approval2.0+
Hawk glasses are on. http://hg.mozilla.org/mozilla-central/rev/7d2cd63fbce9
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0
What's the test to verify this?

1. Open some tabs
2. Open Tab Groups view
3. Rearrange tabs
4. Exit Tab Groups view
5. Crash
6. Restart and Restore

Result:
Tabs restored in order created in step 3?
Verified using Mozilla/5.0 (Windows NT 6.1; rv:2.0) Gecko/20100101 Firefox/4.0.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.