635418 - TabShow & TabHide should cause saveStateDelayed

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Uhh, it apparently doesn't. So if you enter tab view, move things around and even return back to normal view, we won't save the visible state if you crash.

Not really sure how we got to this point like that...

Comment 1

[juan becerra [:juanb]]

Should this block, at least final, for the state loss?

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I *really* don't want to make more blockers, but probably. So soft block final is my vote. Without tests, this will only be the addition of 2 lines of code (actually the same line, twice).

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Won't block, but I will watch like a goddamned hawk for the approval request and agree that this is worth your time, zpao!

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

Ok, I added a little more than 2 lines so that we wouldn't have to get the window from the tab after that's already been done.

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 514271 [details] [diff] [review]
Patch v0.1

r+a=me for final. Please borrow Beltzner's hawk glasses when this lands, to watch the tree with.

Comment 6

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Hawk glasses are on. http://hg.mozilla.org/mozilla-central/rev/7d2cd63fbce9

Comment 7

[u279076]

What's the test to verify this?

1. Open some tabs
2. Open Tab Groups view
3. Rearrange tabs
4. Exit Tab Groups view
5. Crash
6. Restart and Restore

Result:
Tabs restored in order created in step 3?

Comment 8

[Teodosia Pop]

Verified using Mozilla/5.0 (Windows NT 6.1; rv:2.0) Gecko/20100101 Firefox/4.0.