Closed Bug 635458 Opened 9 years ago Closed 9 years ago

Tab look regressed after 580970 with some GTK themes

Categories

(Firefox :: Theme, defect)

All
Linux
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 5
Tracking Status
blocking2.0 --- Macaw+
status2.0 --- .1-fixed

People

(Reporter: micmon, Assigned: dao)

References

Details

(Whiteboard: [fx4-rc-ridealong])

Attachments

(4 files)

Attached image Screenshot
Since the "fix" from 580970 landed, the tab and location toolbars are no longer separated by a thin line, which looks strange on all but the active tab.
Attached image Looks good
It looks fine for me.
Looks fine on my end too. Running Ubuntu 10.10 i386 and tested with both Clearlooks and Clearlooks inverted.
Status: NEW → UNCONFIRMED
Ever confirmed: false
Keywords: qawanted
Mozilla/5.0 (X11; Linux i686; rv:2.0b12pre) Gecko/20110221 Firefox/4.0b12pre

Everything looks ok to me too.
Considering last three comments, setting resolution to WFM.
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
Mozilla/5.0 (X11; Linux i686; rv:2.0b13pre) Gecko/20110303 Firefox/4.0b13pre

Kubuntu / KDE 4.5.1

I can confirm this bug
Attached image Regression in KDE
used to look better
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: WORKSFORME → ---
Attached patch patchSplinter Review
This should help with themes where the menubar appearance doesn't add a bottom border. I have no idea how widespread such themes are.
Assignee: nobody → dao
Status: REOPENED → ASSIGNED
Attachment #516913 - Flags: review?(ventnor.bugzilla)
Keywords: qawanted
Summary: Tab look regressed after 580970 on non-Ubuntu themes → Tab look regressed after 580970 with some GTK themes
Whiteboard: [fx4-rc-ridealong]
Attachment #516913 - Flags: review?(ventnor.bugzilla) → review+
Attachment #516913 - Flags: approval2.0?
Comment on attachment 516913 [details] [diff] [review]
patch

-ing this patch for RC1.
Attachment #516913 - Flags: approval2.0? → approval2.0-
clearing whiteboard request as this is not going to be a ridealong fix.
Whiteboard: [fx4-rc-ridealong]
Adding fx4-rc-ridealong back, as it's present in other bugs despite approval2.0-.

By the way, I don't understand why approval requests aren't just left alone until it's clear that there won't be any ridealongs anymore.
Whiteboard: [fx4-rc-ridealong]
it was decided that this won't be a ridealong.
Whiteboard: [fx4-rc-ridealong]
This should be a ridealong. We don't know how many gtk themes are affected, the patch has no risk.
blocking2.0: --- → ?
Whiteboard: [fx4-rc-ridealong]
Oh. You're asking the triage team to re-consider. I didn't understand that. Sorry. The team will take a second look tomorrow at 11:30. (It was known that it was a low-risk css only change when it was first denied as a ridealong on Monday's meeting.)
Were we to spin a second RC, I would take this patch. We're hoping to not do that, of course.

Dao: are we worried about the potential perf impact of adding a css:shadow, here?
blocking2.0: ? → .x+
(In reply to comment #14)
> Dao: are we worried about the potential perf impact of adding a css:shadow,
> here?

The shadow isn't blurred, so it should be cheap enough. We also use similar shadows elsewhere in the main window.
Comment on attachment 516913 [details] [diff] [review]
patch

Apparently there's going to be an RC2.
Attachment #516913 - Flags: approval2.0- → approval2.0?
http://hg.mozilla.org/projects/cedar/rev/104a8dd9d156
Whiteboard: [fx4-rc-ridealong] → [fx4-rc-ridealong] fixed-in-cedar
http://hg.mozilla.org/mozilla-central/rev/104a8dd9d156
Status: ASSIGNED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Whiteboard: [fx4-rc-ridealong] fixed-in-cedar → [fx4-rc-ridealong]
Target Milestone: --- → Firefox4.2
not blocking 4.0.1 but we will look at the approval request
blocking2.0: .x+ → -
Comment on attachment 516913 [details] [diff] [review]
patch

Approved for the mozilla2.0 repo, a=dveditz for release-drivers
Attachment #516913 - Flags: approval2.0? → approval2.0+
blocking2.0: - → Macaw
Blocks: 580970
Verified on Mozilla/5.0 (X11; Linux i686; rv:2.2a1pre) Gecko/20110405 Firefox/4.2a1pre
Status: RESOLVED → VERIFIED
Target Milestone: Firefox5 → Firefox 5
You need to log in before you can comment on or make changes to this bug.