Closed
Bug 635573
Opened 15 years ago
Closed 14 years ago
IPC test failure: do_get_file("ipc-data.txt") doesn't allow for the file to be missing
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: WeirdAl, Assigned: WeirdAl)
References
Details
(Keywords: testcase)
Attachments
(1 file)
|
640 bytes,
patch
|
Details | Diff | Splinter Review |
TEST-UNEXPECTED-FAIL | .../ipctest/fx-opt/_tests/xpcshell/extensions/ipc-pipe/tests/unit/test_ipcbuffer.js | [run_test : 185] .../ipctest/fx-opt/_tests/xpcshell/extensions/ipc-pipe/tests/unit/ipc-data.txt does not exist
In testing/xpcshell/head.js, the do_get_file() function does take an allowNonExistent argument, but if you don't pass it in as true, the test will abort.
Patch coming.
| Assignee | ||
Comment 1•15 years ago
|
||
I also added a line to remove the ipc-data.txt file at the end of the test.
We should think about creating that file in a temp folder instead, though. Directory services can get that temp folder for us. If you want, I can submit a new patch with that instead.
Assignee: patrick → ajvincent
Attachment #513827 -
Flags: review?(patrick)
Comment 2•15 years ago
|
||
Comment on attachment 513827 [details] [diff] [review]
patch, v1
But I agree with you that it would be better to create the txt file in the temp directory.
Comment 3•14 years ago
|
||
Obsolete - the new subprocess module does not have test cases for ipcbuffer anymore.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
Updated•14 years ago
|
Attachment #513827 -
Flags: review?(patrick)
You need to log in
before you can comment on or make changes to this bug.
Description
•