Closed Bug 635582 Opened 13 years ago Closed 13 years ago

Unqualified function invocation doesn't use the global object the property was gotten from as |this|, part deux!

Categories

(Core :: JavaScript Engine, defect, P1)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 634590
Milestone:
mozilla2.0b12
Tracking Flags:
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: brendan, Assigned: brendan)

References

Details

(Keywords: regression, testcase, Whiteboard: [hardblocker])

Attachments

(1 file, 2 obsolete files)

patch to commit
9.05 KB, patch
brendan
: review+
gal
: approval2.0+
Details | Diff | Splinter Review
Attached patch proposed fix and tests (obsolete) — — Splinter Review 
See bug 634590 comment 74 -- Threat Level Midnight!

/be
Attachment #513837 - Flags: review?(gal)
Summary: Unqualified function invocation doesn't use the global object the property was gotten from as |this| → Unqualified function invocation doesn't use the global object the property was gotten from as |this|, part deux!
Forgot to pass true to the outer f() call.

/be
Attachment #513837 - Attachment is obsolete: true
Attachment #513837 - Flags: review?(gal)
Attachment #513839 - Flags: review?(gal)
Comment on attachment 513839 [details] [diff] [review]
non-clownshoes result for the 'd' test

ComuteThis makes more sense than SlowThis now. I like that we go through the same path for both slow and fast case now. It might cost a cycle, but the interpreter rarely kicks in and this is definitely safe now.
Attachment #513839 - Flags: review?(gal) → review+
Attached patch patch to commit — — Splinter Review 

        Attachment #513839 -
        Attachment is obsolete: true

        Attachment #513842 -
        Flags: review+

    
    

    
  
http://hg.mozilla.org/tracemonkey/rev/c307f596458f

/be
Whiteboard: fixed-in-tracemonkey

    
  

        Attachment #513842 -
        Flags: approval2.0?

    
  
Whiteboard: fixed-in-tracemonkey → [hardblocker][has patch], fixed-in-tracemonkey

    
    

    
  
Comment on attachment 513842 [details] [diff] [review]
patch to commit

The previous (partially incorrect) fix for this was a hardblocker, so is this then.

        Attachment #513842 -
        Flags: approval2.0? → approval2.0+

    
    

    
  
Backed out of TM, the predecessor turned OS X opt orange.

http://hg.mozilla.org/tracemonkey/rev/600fb260cffd
Whiteboard: [hardblocker][has patch], fixed-in-tracemonkey → [hardblocker][has patch]

    
  
Whiteboard: [hardblocker][has patch] → [hardblocker]

    
    

    
  
what is happening with these last two beta N blockers than?

    
    

    
  
(In reply to comment #9)
> what is happening with these last two beta N blockers than?

Please see comment 8.  Apparently, the patch was applied, but something with the code caused a problem on Macintosh OS X operating system.  All operating systems have to test OKAY after the patch is applied for the patch to remain, otherwise it is taken out and rewritten.

    
    

    
  
Dup-ed against the original bug (part I) since both parts were backed out.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE

    
  
Blocks: 671947

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: