63559 - DOMParser loses HTML element attributes

Status: VERIFIED FIXED

(Core :: XML, defect, P2)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

When parsing an XML document that contains HTML elements, we lose attributes on
the HTML elements. We get an assertion that attribute stylesheet could not be
loaded (which is needed to add those attributes).

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I will not be able to check this in for 0.8, moving to 0.9.

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: Proposed fix 1

Comment 3

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I am not completely sure this is the right fix yet, but at least it *seems* to
work. We still try to set the attributes via the stylesheet, but if we do not
get a stylesheet we use the alternative method. It used to be so that if there
was no document we'd use the alternative method.

Comment 4

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: Slightly cleaner fix, GetAttrStyleSheet() checks if document != nsnull

Comment 5

[Johnny Stenback (:jst)]

The last patch looks good to me. r=jst

Comment 6

[vidur (gone)]

Looks good to me as well - sr=vidur. I'm not sure I understand why
nsHTMLUnknownElement doesn't use the generic SetAttribute, but that's a
different issue.

Comment 7

[Brent Hendricks]

This patch didn't work for me when loading an XHTML document using document.load().

Here's a testcase
http://www.ece.rice.edu/~brentmh/swi/js/test.html

--Brent

Comment 8

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: Sample XML file to be loaded with document.load()

Comment 9

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: File that uses document.load() to load previous XML file attachment

Comment 10

[Heikki Toivonen (remove -bugzilla when emailing directly)]

My sample that I just attached (slightly modified from your version) works fine.
Maybe the problem is with your testcase, or maybe it is because your testcase
uses unknown namespace (not XHTML).

Comment 11

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Fix checked in.

Comment 12

[Chris Petersen]

Marking verified fixed in the March 1 build.