Compilation failure in gfxWindowsPlatform.h during compilation without DWrite

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

942 bytes, patch
jfkthame
: review+
Joe Drew (not getting mail)
: approval2.0+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Created attachment 513851 [details] [diff] [review]
fix v1.0

In this configuration cairo_win32_scaled_font_select_font is undefined in gfxWindowsPlatform.h. It's defined in cairo-win32.h, which is included by gfxDWriteFonts.h. Because of that, if DWrite is disabled, cairo-win32.h is missing. The attached patch fixes the problem by always including cairo-win32.h in gfxWindowsPlatform.h.
Attachment #513851 - Flags: review?(jfkthame)
Attachment #513851 - Flags: review?(jfkthame) → review+
(Assignee)

Updated

7 years ago
Attachment #513851 - Flags: approval2.0?
Comment on attachment 513851 [details] [diff] [review]
fix v1.0

As long as this passed try LGTM.
Attachment #513851 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 2

7 years ago
Passed on try:
http://tbpl.mozilla.org/?tree=MozillaTry&rev=873cd4ad4b5c

Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/7019dd8625a8
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.