Closed Bug 635593 Opened 13 years ago Closed 13 years ago

Compilation failure in gfxWindowsPlatform.h during compilation without DWrite

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(1 file)

fix v1.0
942 bytes, patch
jfkthame
: review+
joe
: approval2.0+
Details | Diff | Splinter Review
Attached patch fix v1.0 — — Splinter Review 
In this configuration cairo_win32_scaled_font_select_font is undefined in gfxWindowsPlatform.h. It's defined in cairo-win32.h, which is included by gfxDWriteFonts.h. Because of that, if DWrite is disabled, cairo-win32.h is missing. The attached patch fixes the problem by always including cairo-win32.h in gfxWindowsPlatform.h.
Attachment #513851 - Flags: review?(jfkthame)
Attachment #513851 - Flags: review?(jfkthame) → review+
Attachment #513851 - Flags: approval2.0?
Comment on attachment 513851 [details] [diff] [review]
fix v1.0

As long as this passed try LGTM.
Attachment #513851 - Flags: approval2.0? → approval2.0+
Passed on try:
http://tbpl.mozilla.org/?tree=MozillaTry&rev=873cd4ad4b5c

Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/7019dd8625a8
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.