typo in nsWebHandlerApp.js: OPEN_DEFAULT_WINDOW instead of OPEN_DEFAULTWINDOW

RESOLVED FIXED in mozilla8

Status

Core Graveyard
File Handling
RESOLVED FIXED
7 years ago
a year ago

People

(Reporter: arno renevier, Assigned: arno renevier)

Tracking

Trunk
mozilla8
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Hi,
in uriloader/exthandler/nsWebHandlerApp.js, we have

    // openURI
    browserDOMWin.openURI(uriToSend,
                          null, // no window.opener 
                          Ci.nsIBrowserDOMWindow.OPEN_DEFAULT_WINDOW,
                          Ci.nsIBrowserDOMWindow.OPEN_NEW);

But nsIBrowserDOMWindow.idl says it should be OPEN_DEFAULTWINDOW (without the second underscore).
This is problaby harmless because nsIBrowserDOMWindow.OPEN_DEFAULTWINDOW because is 0

Updated

7 years ago
Component: General → File Handling
QA Contact: general → file-handling
(Assignee)

Comment 1

6 years ago
Created attachment 546306 [details] [diff] [review]
fix typo
Assignee: nobody → arno
Attachment #546306 - Flags: review?(gavin.sharp)
Attachment #546306 - Flags: review?(gavin.sharp) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.