The default bug view has changed. See this FAQ.

ContentParent NS_IMPL_ISUPPORTS doesn't include nsIAccelerationListener

RESOLVED FIXED in mozilla8

Status

()

Core
IPC
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jdm, Assigned: Evan Shaw)

Tracking

unspecified
mozilla8
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=jdm][inbound], URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
This seems incorrect to me.

Comment 1

6 years ago
It does seem odd to me too.

CCing the patch writer and reviewer.

Comment 2

6 years ago
sounds like a bug.  we probably never QI only static cast to it.
(Reporter)

Comment 3

6 years ago
Relevant code in the URL field.  This is an easy change of simply adding nsIAccelerationListener to the list of supported interfaces.
Whiteboard: [good first bug]
(Reporter)

Updated

6 years ago
Whiteboard: [good first bug] → [good first bug][mentor=jdm]
(Assignee)

Comment 4

6 years ago
Created attachment 547639 [details] [diff] [review]
Add nsIDeviceMotionListener to ContentParent's NS_IMPL_ISUPPORTS

Patch attached. nsIAccelerationListener was renamed to nsIDeviceMotionListener at some point after this bug was filed.
Attachment #547639 - Flags: review?
(Reporter)

Comment 5

6 years ago
Comment on attachment 547639 [details] [diff] [review]
Add nsIDeviceMotionListener to ContentParent's NS_IMPL_ISUPPORTS

Nice detective work.  Would you mind putting together a new version that follows these guidelines to make checking it in easy: https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f ?
Attachment #547639 - Flags: review? → review+
(Assignee)

Comment 6

6 years ago
Hmmm, I thought I'd already done that. What's my patch lacking from those directions?
(Reporter)

Comment 7

6 years ago
Oh, weird, I could have sworn is was missing. I'll push this with the r=jdm annotation.
(Reporter)

Comment 8

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/d06068f0fe1b
Assignee: nobody → edsrzf
Whiteboard: [good first bug][mentor=jdm] → [good first bug][mentor=jdm][inbound]
Target Milestone: --- → mozilla8
http://hg.mozilla.org/mozilla-central/rev/d06068f0fe1b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.