Last Comment Bug 635658 - ContentParent NS_IMPL_ISUPPORTS doesn't include nsIAccelerationListener
: ContentParent NS_IMPL_ISUPPORTS doesn't include nsIAccelerationListener
Status: RESOLVED FIXED
[good first bug][mentor=jdm][inbound]
:
Product: Core
Classification: Components
Component: IPC (show other bugs)
: unspecified
: x86 Linux
: -- normal (vote)
: mozilla8
Assigned To: Evan Shaw
:
Mentors:
http://mxr.mozilla.org/mozilla-centra...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-20 23:39 PST by Josh Matthews [:jdm]
Modified: 2011-07-25 06:06 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add nsIDeviceMotionListener to ContentParent's NS_IMPL_ISUPPORTS (1.10 KB, patch)
2011-07-22 02:19 PDT, Evan Shaw
josh: review+
Details | Diff | Review

Description Josh Matthews [:jdm] 2011-02-20 23:39:31 PST
This seems incorrect to me.
Comment 1 Alon Zakai (:azakai) 2011-02-22 10:04:46 PST
It does seem odd to me too.

CCing the patch writer and reviewer.
Comment 2 Doug Turner (:dougt) 2011-02-22 13:07:55 PST
sounds like a bug.  we probably never QI only static cast to it.
Comment 3 Josh Matthews [:jdm] 2011-04-10 11:42:24 PDT
Relevant code in the URL field.  This is an easy change of simply adding nsIAccelerationListener to the list of supported interfaces.
Comment 4 Evan Shaw 2011-07-22 02:19:21 PDT
Created attachment 547639 [details] [diff] [review]
Add nsIDeviceMotionListener to ContentParent's NS_IMPL_ISUPPORTS

Patch attached. nsIAccelerationListener was renamed to nsIDeviceMotionListener at some point after this bug was filed.
Comment 5 Josh Matthews [:jdm] 2011-07-22 08:48:01 PDT
Comment on attachment 547639 [details] [diff] [review]
Add nsIDeviceMotionListener to ContentParent's NS_IMPL_ISUPPORTS

Nice detective work.  Would you mind putting together a new version that follows these guidelines to make checking it in easy: https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f ?
Comment 6 Evan Shaw 2011-07-22 14:03:56 PDT
Hmmm, I thought I'd already done that. What's my patch lacking from those directions?
Comment 7 Josh Matthews [:jdm] 2011-07-22 14:24:46 PDT
Oh, weird, I could have sworn is was missing. I'll push this with the r=jdm annotation.
Comment 9 Marco Bonardo [::mak] 2011-07-25 06:06:49 PDT
http://hg.mozilla.org/mozilla-central/rev/d06068f0fe1b

Note You need to log in before you can comment on or make changes to this bug.