635719 - require("simple-storage") is writable

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Dietrich Ayala (:dietrich)]

you can get/set properties on the object returned by require("simple-storage");

i noticed this because i was iterating over the keys in what i thought was my storage data, and saw the internal bits hanging off there.

others might also make this mistake of doing:

let storage = require("simple-storage");

instead of:

let storage = require("simple-storage").storage;

maybe there's a way to construct this such that it'll resolve both issues?

Comment 1

[Myk Melez [:myk] [@mykmelez]]

(automatic reprioritization of 1.0 bugs)

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(Pushing all open bugs to the --- milestone for the new triage system)

Comment 3

[Erik Vold]

atm we can no longer get/set arbitrary properties to require('simple-storage').

Neither case will throw an error which is what I thought might be desirable, but that will depend on Proxy's to work across sandboxes (bug 706041) afaict.

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

Taking myself off things that I won't be able to get to for awhile.

Comment 5

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562