Closed Bug 635719 Opened 11 years ago Closed 4 years ago

require("simple-storage") is writable

Categories

(Add-on SDK Graveyard :: General, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: dietrich, Unassigned)

References

Details

you can get/set properties on the object returned by require("simple-storage");

i noticed this because i was iterating over the keys in what i thought was my storage data, and saw the internal bits hanging off there.

others might also make this mistake of doing:

let storage = require("simple-storage");

instead of:

let storage = require("simple-storage").storage;

maybe there's a way to construct this such that it'll resolve both issues?
OS: Mac OS X → All
Priority: -- → P3
Hardware: x86 → All
Target Milestone: --- → 1.0
(automatic reprioritization of 1.0 bugs)
Priority: P3 → P2
Target Milestone: 1.0 → 1.1
(Pushing all open bugs to the --- milestone for the new triage system)
Target Milestone: 1.1 → ---
Assignee: nobody → erikvvold
Status: NEW → ASSIGNED
Depends on: 706041
atm we can no longer get/set arbitrary properties to require('simple-storage').

Neither case will throw an error which is what I thought might be desirable, but that will depend on Proxy's to work across sandboxes (bug 706041) afaict.
Depends on: 703537
Taking myself off things that I won't be able to get to for awhile.
Assignee: erikvvold → nobody
https://bugzilla.mozilla.org/show_bug.cgi?id=1399562
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.