Closed
Bug 635760
Opened 14 years ago
Closed 14 years ago
Separate tests for master password into different test modules
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(3 files, 1 obsolete file)
|
19.19 KB,
patch
|
gmealer
:
review+
|
Details | Diff | Splinter Review |
|
19.49 KB,
patch
|
gmealer
:
review+
|
Details | Diff | Splinter Review |
|
19.41 KB,
patch
|
gmealer
:
review+
|
Details | Diff | Splinter Review |
We have a strange test failure in testMasterPassword, but before I want to look at it, we should factor out all the test functions into different test modules. That makes the file a lot cleaner.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #514053 -
Flags: review?(gmealer)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Now with the new files added.
Attachment #514053 -
Attachment is obsolete: true
Attachment #514053 -
Flags: review?(gmealer)
Attachment #514055 -
Flags: review?(gmealer)
Henrik,
Before I approve, why remove the teardown that cleans up the logins?
|
|
Assignee | |
Comment 4•14 years ago
|
||
The teardown is a left-over from the start when it was a non-restart test. Now having it as a restart test there is no need to reset the passwords at the end.
Comment on attachment 514055 [details] [diff] [review]
Patch v1.1 [checked-in]
Thanks for the clarification, r+
Attachment #514055 -
Flags: review?(gmealer) → review+
|
|
Assignee | |
Comment 6•14 years ago
|
||
Comment on attachment 514055 [details] [diff] [review]
Patch v1.1 [checked-in]
Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/48981adaf22c
Attachment #514055 -
Attachment description: Patch v1.1 → Patch v1.1 [checked-in]
|
|
Assignee | |
Comment 7•14 years ago
|
||
Attachment #514467 -
Flags: review?(gmealer)
|
|
Assignee | |
Comment 8•14 years ago
|
||
Attachment #514505 -
Flags: review?(gmealer)
Comment on attachment 514467 [details] [diff] [review]
Backport 1.9.2
r+, looks fine.
Attachment #514467 -
Flags: review?(gmealer) → review+
Attachment #514505 -
Flags: review?(gmealer) → review+
Oops, forgot to comment, 1.9.1 is r+ too.
|
|
Assignee | |
Comment 11•14 years ago
|
||
Landed both backports:
http://hg.mozilla.org/qa/mozmill-tests/rev/fe55fcf74bc4 (1.9.2)
http://hg.mozilla.org/qa/mozmill-tests/rev/0fca0396eaeb (1.9.1)
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•