The default bug view has changed. See this FAQ.

Fix debugQATextEditorShell so that it works

RESOLVED FIXED in seamonkey2.1b3

Status

SeaMonkey
Composer
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

(Blocks: 1 bug)

Trunk
seamonkey2.1b3
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 514098 [details] [diff] [review]
Fix texteditor patch v0.1

I noticed whilst working on another bug that debugQATextEditorShell was fairly broken. This patch fixes the majority of the issues - the observer adding/removal issue will be dealt with in bug 606683 (or a related bug).
Attachment #514098 - Flags: review?(neil)
Comment on attachment 514098 [details] [diff] [review]
Fix texteditor patch v0.1

>+        toggletoolbar="true"
>+        lightweightthemes="true"
>+        lightweightthemesfooter="status-bar"

Oops.

Comment 2

6 years ago
Comment on attachment 514098 [details] [diff] [review]
Fix texteditor patch v0.1

> function ShowHideToolbarSeparators(toolbar) {
>+  // Make sure the toolbar actually exists.
>+  if (!toolbar)
>+    return;
This is all going away with custom toolbars right? r=me if it is.

>       <!-- tasks menu filled from tasksOverlay -->
>-      <menu accesskey="t" id="tasksMenu"/>
>+      <menu id="tasksMenu"/>
> 
>       <!-- help menu filled from globalOverlay -->
>-      <menu accesskey="h" id="menu_Help"/>
>+      <menu id="menu_Help"/>
I don't suppose you could include the window menu while you're there?
Attachment #514098 - Flags: review?(neil) → review+
(Assignee)

Comment 3

6 years ago
(In reply to comment #2)
> Comment on attachment 514098 [details] [diff] [review]
> Fix texteditor patch v0.1
> 
> > function ShowHideToolbarSeparators(toolbar) {
> >+  // Make sure the toolbar actually exists.
> >+  if (!toolbar)
> >+    return;
> This is all going away with custom toolbars right? r=me if it is.
Yes, it will be.

> >       <!-- tasks menu filled from tasksOverlay -->
> >-      <menu accesskey="t" id="tasksMenu"/>
> >+      <menu id="tasksMenu"/>
> > 
> >       <!-- help menu filled from globalOverlay -->
> >-      <menu accesskey="h" id="menu_Help"/>
> >+      <menu id="menu_Help"/>
> I don't suppose you could include the window menu while you're there?
Done.
(Assignee)

Comment 4

6 years ago
Created attachment 514298 [details] [diff] [review]
Fix Text Editor patch v0.2 [Checked in: Comment 4]

As checked in.
http://hg.mozilla.org/comm-central/rev/c187bbef92f4
Attachment #514098 - Attachment is obsolete: true
Attachment #514298 - Flags: review+
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3
You need to log in before you can comment on or make changes to this bug.