Last Comment Bug 635792 - Fix debugQATextEditorShell so that it works
: Fix debugQATextEditorShell so that it works
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Composer (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b3
Assigned To: Ian Neal
:
:
Mentors:
Depends on:
Blocks: 606683
  Show dependency treegraph
 
Reported: 2011-02-21 16:42 PST by Ian Neal
Modified: 2011-02-22 13:47 PST (History)
2 users (show)
iann_bugzilla: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Fix texteditor patch v0.1 (7.35 KB, patch)
2011-02-21 16:42 PST, Ian Neal
neil: review+
Details | Diff | Splinter Review
Fix Text Editor patch v0.2 [Checked in: Comment 4] (7.44 KB, patch)
2011-02-22 13:46 PST, Ian Neal
iann_bugzilla: review+
Details | Diff | Splinter Review

Description Ian Neal 2011-02-21 16:42:03 PST
Created attachment 514098 [details] [diff] [review]
Fix texteditor patch v0.1

I noticed whilst working on another bug that debugQATextEditorShell was fairly broken. This patch fixes the majority of the issues - the observer adding/removal issue will be dealt with in bug 606683 (or a related bug).
Comment 1 Jens Hatlak (:InvisibleSmiley) 2011-02-21 23:29:58 PST
Comment on attachment 514098 [details] [diff] [review]
Fix texteditor patch v0.1

>+        toggletoolbar="true"
>+        lightweightthemes="true"
>+        lightweightthemesfooter="status-bar"

Oops.
Comment 2 neil@parkwaycc.co.uk 2011-02-22 08:35:43 PST
Comment on attachment 514098 [details] [diff] [review]
Fix texteditor patch v0.1

> function ShowHideToolbarSeparators(toolbar) {
>+  // Make sure the toolbar actually exists.
>+  if (!toolbar)
>+    return;
This is all going away with custom toolbars right? r=me if it is.

>       <!-- tasks menu filled from tasksOverlay -->
>-      <menu accesskey="t" id="tasksMenu"/>
>+      <menu id="tasksMenu"/>
> 
>       <!-- help menu filled from globalOverlay -->
>-      <menu accesskey="h" id="menu_Help"/>
>+      <menu id="menu_Help"/>
I don't suppose you could include the window menu while you're there?
Comment 3 Ian Neal 2011-02-22 13:45:12 PST
(In reply to comment #2)
> Comment on attachment 514098 [details] [diff] [review]
> Fix texteditor patch v0.1
> 
> > function ShowHideToolbarSeparators(toolbar) {
> >+  // Make sure the toolbar actually exists.
> >+  if (!toolbar)
> >+    return;
> This is all going away with custom toolbars right? r=me if it is.
Yes, it will be.

> >       <!-- tasks menu filled from tasksOverlay -->
> >-      <menu accesskey="t" id="tasksMenu"/>
> >+      <menu id="tasksMenu"/>
> > 
> >       <!-- help menu filled from globalOverlay -->
> >-      <menu accesskey="h" id="menu_Help"/>
> >+      <menu id="menu_Help"/>
> I don't suppose you could include the window menu while you're there?
Done.
Comment 4 Ian Neal 2011-02-22 13:46:58 PST
Created attachment 514298 [details] [diff] [review]
Fix Text Editor patch v0.2 [Checked in: Comment 4]

As checked in.
http://hg.mozilla.org/comm-central/rev/c187bbef92f4

Note You need to log in before you can comment on or make changes to this bug.