636058 - Errors on import, mac only (Components.classes[contractids[fp.filterIndex]] is undefined)

Status: RESOLVED FIXED

(Calendar :: Import and Export, defect)

Description

[Bruce Parks]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13
Build Identifier: Lightning 1.0 beta2

Imports of .ics files consistently fail.  Console message is -

Error: An error occurred executing the calendar_import_command command: [Exception... "'[JavaScript Error: 
Attempts to import a calendar previously exported by both Lightning and Apple iCal fail.  Console error message follows:

"Components.classes[contractids[fp.filterIndex]] is undefined" {file: "chrome://calendar/content/import-export.js" line: 99}]' when calling method: [nsIController::doCommand]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://global/content/globalOverlay.js :: goDoCommand :: line 71"  data: yes]
Source File: chrome://global/content/globalOverlay.js
Line: 75

Same files can be successfully imported into Apple iCal no problem.

Reproducible: Always

Steps to Reproduce:
1.Export a calendar to .ics file from any calendar software
2.Import into Lightning
3.
Actual Results:  
Nothing.  Console error listed in details above.

Expected Results:  
Imported calendar data should appear.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Confirmed, getting this too.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Strange, I'm not getting this bug anymore. I even tried with a new profile. Anyway, here is a patch that will at least work around the issue if it should show up.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Bruce, if you are still around, maybe you could test this patch, or maybe provide reliable steps to reproduce?

Comment 4

[Martin Schröder [:mschroeder]]

Comment on attachment 548117 [details] [diff] [review]
Fix - v1

Tried to reproduce and observed another problem. I'm going to postpone the review.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Martin, I'd like to see this for the next release on Sept. 27th, do you think you could review this patch and/or fix the other problem you observed?

Comment 6

[Martin Schröder [:mschroeder]]

(In reply to Philipp Kewisch [:Fallen] from comment #5)
> Martin, I'd like to see this for the next release on Sept. 27th, do you
> think you could review this patch and/or fix the other problem you observed?

Sorry, I won't be able to review/fix this in time.

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Ok, I understand. Can you tell us about the problem you were observing?

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 548117 [details] [diff] [review]
Fix - v1

Matthew, could you give this a simple code review without testing?

Comment 9

[Matthew Mecca [:mmecca]]

Comment on attachment 548117 [details] [diff] [review]
Fix - v1

Untested, but looks good codewise. r=mmecca

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/d7118b9e976e>
-> FIXED

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to comm-aurora <http://hg.mozilla.org/releases/comm-aurora/rev/894ab91e98b5>

Comment 12

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to comm-beta <http://hg.mozilla.org/releases/comm-beta/rev/fb023863690b>