Errors on import, mac only (Components.classes[contractids[fp.filterIndex]] is undefined)

RESOLVED FIXED in 1.0b7

Status

RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: brucejparks, Assigned: Fallen)

Tracking

unspecified
1.0b7
x86
Mac OS X
Bug Flags:
blocking-calendar1.0 +

Details

(Whiteboard: [needed beta][no l10n impact])

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13
Build Identifier: Lightning 1.0 beta2

Imports of .ics files consistently fail.  Console message is -

Error: An error occurred executing the calendar_import_command command: [Exception... "'[JavaScript Error: 
Attempts to import a calendar previously exported by both Lightning and Apple iCal fail.  Console error message follows:

"Components.classes[contractids[fp.filterIndex]] is undefined" {file: "chrome://calendar/content/import-export.js" line: 99}]' when calling method: [nsIController::doCommand]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://global/content/globalOverlay.js :: goDoCommand :: line 71"  data: yes]
Source File: chrome://global/content/globalOverlay.js
Line: 75

Same files can be successfully imported into Apple iCal no problem.

Reproducible: Always

Steps to Reproduce:
1.Export a calendar to .ics file from any calendar software
2.Import into Lightning
3.
Actual Results:  
Nothing.  Console error listed in details above.

Expected Results:  
Imported calendar data should appear.
Confirmed, getting this too.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Exports work, imports do not. → Errors on import, mac only (Components.classes[contractids[fp.filterIndex]] is undefined)
(Assignee)

Updated

7 years ago
Flags: blocking-calendar1.0+
Created attachment 548117 [details] [diff] [review]
Fix - v1

Strange, I'm not getting this bug anymore. I even tried with a new profile. Anyway, here is a patch that will at least work around the issue if it should show up.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #548117 - Flags: review?(mschroeder)
(Assignee)

Updated

7 years ago
Whiteboard: [not needed beta][no l10n impact][needs review]
Bruce, if you are still around, maybe you could test this patch, or maybe provide reliable steps to reproduce?
Comment on attachment 548117 [details] [diff] [review]
Fix - v1

Tried to reproduce and observed another problem. I'm going to postpone the review.
Martin, I'd like to see this for the next release on Sept. 27th, do you think you could review this patch and/or fix the other problem you observed?
Whiteboard: [not needed beta][no l10n impact][needs review] → [needed beta][no l10n impact][needs review]
(In reply to Philipp Kewisch [:Fallen] from comment #5)
> Martin, I'd like to see this for the next release on Sept. 27th, do you
> think you could review this patch and/or fix the other problem you observed?

Sorry, I won't be able to review/fix this in time.
Ok, I understand. Can you tell us about the problem you were observing?
Comment on attachment 548117 [details] [diff] [review]
Fix - v1

Matthew, could you give this a simple code review without testing?
Attachment #548117 - Flags: review?(mschroeder) → review?(matthew.mecca)
Comment on attachment 548117 [details] [diff] [review]
Fix - v1

Untested, but looks good codewise. r=mmecca
Attachment #548117 - Flags: review?(matthew.mecca) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/d7118b9e976e>
-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Trunk
Backported to comm-aurora <http://hg.mozilla.org/releases/comm-aurora/rev/894ab91e98b5>
Target Milestone: Trunk → 1.0b8
Backported to comm-beta <http://hg.mozilla.org/releases/comm-beta/rev/fb023863690b>
Target Milestone: 1.0b8 → 1.0b7
(Assignee)

Updated

7 years ago
Whiteboard: [needed beta][no l10n impact][needs review] → [needed beta][no l10n impact]
You need to log in before you can comment on or make changes to this bug.