Last Comment Bug 636076 - Port a little more of |Bug 461979 - make profile info easier to localize| to SeaMonkey
: Port a little more of |Bug 461979 - make profile info easier to localize| to ...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: seamonkey2.1b3
Assigned To: Serge Gautherie (:sgautherie)
:
Mentors:
Depends on: 351476 475113
Blocks: 554993
  Show dependency treegraph
 
Reported: 2011-02-22 19:41 PST by Serge Gautherie (:sgautherie)
Modified: 2011-03-06 03:34 PST (History)
3 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
(Av1) Sort a list, Add an -f parameter [Checked in: Comment 6] (1.22 KB, patch)
2011-02-22 19:43 PST, Serge Gautherie (:sgautherie)
kairo: review+
Details | Diff | Review
(Bv1) Fix 2 unrelated nits in README_FILES processing, per bug 351476 [Checked in: Comment 7] (992 bytes, patch)
2011-02-22 20:00 PST, Serge Gautherie (:sgautherie)
kairo: review+
Details | Diff | Review

Description Serge Gautherie (:sgautherie) 2011-02-22 19:41:50 PST
Just to reduce differences a little.

NB: I'm still leaving out some bookmark related not-or-differently-ported lines.
Comment 1 Serge Gautherie (:sgautherie) 2011-02-22 19:43:40 PST
Created attachment 514405 [details] [diff] [review]
(Av1) Sort a list, Add an -f parameter
[Checked in: Comment 6]
Comment 2 Serge Gautherie (:sgautherie) 2011-02-22 20:00:08 PST
Created attachment 514411 [details] [diff] [review]
(Bv1) Fix 2 unrelated nits in README_FILES processing, per bug 351476
[Checked in: Comment 7]
Comment 3 Robert Kaiser (not working on stability any more) 2011-03-05 08:56:59 PST
Callek. I expect some or all of those nits to conflict with your changes in bug 554993.
Comment 4 Justin Wood (:Callek) 2011-03-05 09:49:34 PST
(In reply to comment #3)
> Callek. I expect some or all of those nits to conflict with your changes in bug
> 554993.

Serge, KaiRo mentioned here and in IRC that he had nits for you to address, but I don't see them here. Can you please hold off on landing these until I get his answer on that? [note: I'll let this land before my patch, will rebase on top of you later tonight]
Comment 5 Robert Kaiser (not working on stability any more) 2011-03-05 14:16:42 PST
(In reply to comment #4)
> Serge, KaiRo mentioned here and in IRC that he had nits for you to address

No, I didn't mean I have nites from him to address, but that those patches just fix nits.
Comment 6 Serge Gautherie (:sgautherie) 2011-03-06 03:33:08 PST
Comment on attachment 514405 [details] [diff] [review]
(Av1) Sort a list, Add an -f parameter
[Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/adb3096ec8a7
Comment 7 Serge Gautherie (:sgautherie) 2011-03-06 03:33:31 PST
Comment on attachment 514411 [details] [diff] [review]
(Bv1) Fix 2 unrelated nits in README_FILES processing, per bug 351476
[Checked in: Comment 7]

http://hg.mozilla.org/comm-central/rev/f7d1c7c1f702

Note You need to log in before you can comment on or make changes to this bug.