636143 - Full screen tab bar doesn't drop down after minimize and top of content is cut off.

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Bebe]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/534.13 (KHTML, like Gecko) Chrome/9.0.597.98 Safari/534.13
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b12) Gecko/20100101 Firefox/4.0b12

After reboot, in full screen mode, if  minimizing and the maximizing FF, the tab bar doesn't drop down

Reproducible: Always

Steps to Reproduce:
1.  Create a new profile on Firefox
2.  Hide the menu bar
3.  Maximize the Firefox window
4.  Press F11 to enter full screen mode
5.  Verify that autohide option works
6.  Exit Firefox
7.  Open Firefox(on the same profile)
8.  Verify that autohide option works
9.  Minimize Firefox
10. Maximize Firefox
11. Verify that autohide option works
Actual Results:  
10. The autohide option doesn't work


Expected Results:  
7.  The Firefox should open in fullscreen mode
10. The autohide function should work

Comment 1

[Jim Mathies [:jimm]]

Potentially fixed in bug 616793 which should be in the 2/7 nightly. Can you test the latest to see if this is a dupe?

Comment 2

[Alex Lakatos[:AlexLakatos]]

This is logged on today's Fx4b12 RC build1.

Comment 3

[Alice0775 White]

Attachment: screenshot

And after restore window from Minimize state, top of content is cut off and scroll arrow is positioned outside screen.

Comment 4

[Alice0775 White]

This also happens on Windows7 Aero/AeroBasic/Classic.
http://hg.mozilla.org/mozilla-central/rev/f8279991d58f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b13pre) Gecko/20110223 Firefox/4.0b13pre ID:20110223030416

Comment 5

[Bebe]

Regression range: 

Last good:
http://hg.mozilla.org/mozilla-central/rev/4c62984f12d1
Mozilla/5.0 (Windows NT 5.1; rv:2.0b12pre) Gecko/20110207 Firefox/4.0b12pre


First bad: 
http://hg.mozilla.org/mozilla-central/rev/3470891975c7
Mozilla/5.0 (Windows NT 5.1; rv:2.0b12pre) Gecko/20110208 Firefox/4.0b12pre

Push log:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4c62984f12d1&tochange=3470891975c7

Comment 6

[Alice0775 White]

I reproduced the problem on http://hg.mozilla.org/mozilla-central/rev/4c62984f12d1
Mozilla/5.0 (Windows NT 5.1; rv:2.0b12pre) Gecko/20110207 Firefox/4.0b12pre

I think this problem happens since the following cset.
For WindowsXP, Classic:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f26255ffe0c9&tochange=a0d6e4d37273
For Windows7Aero:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=94f92b34e535&tochange=f0c025ec62c9

Comment 7

[Ed Morley [:emorley]]

(In reply to comment #6)
> I think this problem happens since the following cset.

This issue was thought to be fixed in bug 616793, which landed after those ranges.

Can you find a regression range after 2011-02-08 or did the fix not work in all cases?

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Because this relies on a non-standard configuration (hiding the menuBar on XP) we won't block on it. But really really hope it's fixed!

Comment 9

[Jim Mathies [:jimm]]

You can reproduce this simply by:

1) go full screen
2) minimize
3) restore

I'll work up a fix.

Comment 10

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

This only happens when the browser started in fullscreen mode, right?

Looks like that is the case covered by that if (mFullscreenMode) removed in bug 636143. for some reason GetWindowPlacement returns SW_SHOWNORMAL rather than SW_SHOWMAXIMIZED in this situation

Comment 11

[Jim Mathies [:jimm]]

Comment on attachment 514868 [details] [diff] [review]
Patch

That fixes the problem. Thanks felipe.

Comment 12

[Asa Dotzler [:asa]]

(In reply to comment #9)
> You can reproduce this simply by:
> 
> 1) go full screen
> 2) minimize
> 3) restore

Does this happen with the menubar showing (the default Win XP toolbar config?)

Comment 13

[Alice0775 White]

BTW,
Does this bug cover only windows xp?
See Comment 4, this bug happens on Windows7 Aero.
Should I need create a new bug for Windows7 Aero?

Comment 14

[:Felipe Gomes (needinfo for replies!)]

That shouldn't be necessary, this bug should cover them all. I tested the fix on win7 aero.

(Of course, that is assuming that all of the reports here were the same problem.. it's not entirely clear given the different regression ranges posted above)

Comment 15

[:Felipe Gomes (needinfo for replies!)]

a tryserver build should appear here soon: http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/[e-mail]-cf45d4fe3a0d

Comment 16

[Alice0775 White]

(In reply to comment #15)

The tryserver build works very well on Windows7 Aero/AeroBasic/Classic.

Comment 17

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 514868 [details] [diff] [review]
Patch

a=beltzner

Please add the in-litmus? flag!

Comment 18

[:Felipe Gomes (needinfo for replies!)]

http://hg.mozilla.org/mozilla-central/rev/7da0462c1301

Comment 19

[Bebe]

verified on  Mozilla/5.0 (Windows NT 5.1; rv:2.0b13pre) Gecko/20110227 Firefox/4.0b13pre

Comment 20

[AndreiD[QA]]

Works For Me on:
Mozilla/5.0 (Windows NT 6.1; rv:2.0) Gecko/20100101 Firefox/4.0