Closed
Bug 636202
Opened 14 years ago
Closed 14 years ago
Turn ipc/ipdl/ipdl/type.py Python 2/3-agnostic
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: gkw, Assigned: gkw)
References
Details
Attachments
(1 file)
|
841 bytes,
patch
|
cjones
:
review+
benjamin
:
approval2.0-
|
Details | Diff | Splinter Review |
Turn ipc/ipdl/ipdl/type.py Python 2/3-agnostic - Python 3 does not support string exceptions.
Attachment #514534 -
Flags: review?(jones.chris.g)
|
||
Updated•14 years ago
|
Attachment #514534 -
Flags: review?(jones.chris.g) → review+
|
Assignee | |
Comment 1•14 years ago
|
||
Comment on attachment 514534 [details] [diff] [review]
patch
Asking for approval2.0 - this patch is totally risk-free as it merely changes Python syntax to be consistent across-the-board. The new code works on both Python 2.x and 3.x whereas the old line does not work in 3.x.
Attachment #514534 -
Flags: approval2.0?
If I had the powers to approve this, I would.
|
||
Comment 3•14 years ago
|
||
Comment on attachment 514534 [details] [diff] [review]
patch
Really, unless it's high-value we're not approving.
Attachment #514534 -
Flags: approval2.0? → approval2.0-
|
|
Assignee | |
Comment 4•14 years ago
|
||
This can wait then, setting checkin-needed so I hope it isn't forgotten after Fx 4 comes out.
Keywords: checkin-needed
|
||
Comment 5•14 years ago
|
||
Please reset checkin-needed post 2.0.
Blocks: post2.0
Keywords: checkin-needed
|
|
||
Updated•14 years ago
|
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → gary
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: checkin-needed
|
||
Updated•14 years ago
|
Keywords: checkin-needed
|
|
||
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: checkin-needed
Target Milestone: --- → mozilla2.2
You need to log in
before you can comment on or make changes to this bug.
Description
•