Closed Bug 636245 Opened 9 years ago Closed 7 years ago

Device Manager window size is hardcoded in XUL

Categories

(Core Graveyard :: Security: UI, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
mozilla17

People

(Reporter: marcoos, Assigned: marcoos)

References

Details

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/source/security/manager/pki/resources/content/device_manager.xul#53

style="width: 52em; height: 32em;"

This should be replaced with an entity and made localizable.
Blocks: 91897
Attached patch PatchSplinter Review
This moves the width and height CSS properties to &devmgr.style;.
Attachment #580192 - Flags: review?(l10n)
Comment on attachment 580192 [details] [diff] [review]
Patch

Review of attachment 580192 [details] [diff] [review]:
-----------------------------------------------------------------

Looks OK to me, but Kai should do the real review here.
Attachment #580192 - Flags: review?(l10n)
Attachment #580192 - Flags: review?(kaie)
Attachment #580192 - Flags: feedback+
Assignee: nobody → marcoos+bmo
Kai, can you review this?
Assignee: marcoos+bmo → ui
Comment on attachment 580192 [details] [diff] [review]
Patch

r=kaie
Attachment #580192 - Flags: review?(kaie) → review+
Landing without Try results since this doesn't functionally change anything.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e79bf6f458f7

Marek, please make sure that future patches you attach include the necessary hg metadata so that they're more checkin-ready. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Assignee: ui → marcoos+bmo
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e79bf6f458f7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.