Last Comment Bug 636245 - Device Manager window size is hardcoded in XUL
: Device Manager window size is hardcoded in XUL
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Security: UI (show other bugs)
: Trunk
: All All
: -- minor (vote)
: mozilla17
Assigned To: Marek Stępień [:marcoos, inactive]
:
Mentors:
Depends on:
Blocks: 91897
  Show dependency treegraph
 
Reported: 2011-02-23 13:20 PST by Marek Stępień [:marcoos, inactive]
Modified: 2012-08-16 06:18 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.41 KB, patch)
2011-12-08 14:13 PST, Marek Stępień [:marcoos, inactive]
kaie: review+
l10n: feedback+
Details | Diff | Splinter Review

Description Marek Stępień [:marcoos, inactive] 2011-02-23 13:20:38 PST
http://mxr.mozilla.org/mozilla-central/source/security/manager/pki/resources/content/device_manager.xul#53

style="width: 52em; height: 32em;"

This should be replaced with an entity and made localizable.
Comment 1 Marek Stępień [:marcoos, inactive] 2011-12-08 14:13:18 PST
Created attachment 580192 [details] [diff] [review]
Patch

This moves the width and height CSS properties to &devmgr.style;.
Comment 2 Axel Hecht [:Pike] 2011-12-08 14:39:28 PST
Comment on attachment 580192 [details] [diff] [review]
Patch

Review of attachment 580192 [details] [diff] [review]:
-----------------------------------------------------------------

Looks OK to me, but Kai should do the real review here.
Comment 3 Marek Stępień [:marcoos, inactive] 2012-04-09 13:29:15 PDT
Kai, can you review this?
Comment 4 Kai Engert (:kaie) 2012-08-15 01:19:49 PDT
Comment on attachment 580192 [details] [diff] [review]
Patch

r=kaie
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-08-15 18:03:52 PDT
Landing without Try results since this doesn't functionally change anything.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e79bf6f458f7

Marek, please make sure that future patches you attach include the necessary hg metadata so that they're more checkin-ready. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Comment 6 Ed Morley [:emorley] 2012-08-16 06:18:09 PDT
https://hg.mozilla.org/mozilla-central/rev/e79bf6f458f7

Note You need to log in before you can comment on or make changes to this bug.