636251 - Use JSOPTION_NO_SCRIPT_RVAL in nsFrameMessageManager.cpp

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Michael Wu [:mwu]]

Attachment: Use JSOPTION_NO_SCRIPT_RVAL in nsFrameMessageManager.cpp

The return value is never used so we can use JSOPTION_NO_SCRIPT_RVAL and pass null.

Comment 1

[Olli Pettay [:smaug][[e-mail]] (vacation-ish -> Aug 1)]

Comment on attachment 514589 [details] [diff] [review]
Use JSOPTION_NO_SCRIPT_RVAL in nsFrameMessageManager.cpp

I can't review this, since I haven't managed to find any good
documentation when JSOPTION_NO_SCRIPT_RVAL should be set and when unset.

Why couldn't it be set when mCx is created and never unset?

Comment 2

[Michael Wu [:mwu]]

(In reply to comment #1)
> Comment on attachment 514589 [details] [diff] [review]
> Use JSOPTION_NO_SCRIPT_RVAL in nsFrameMessageManager.cpp
> 
> I can't review this, since I haven't managed to find any good
> documentation when JSOPTION_NO_SCRIPT_RVAL should be set and when unset.
> 
> Why couldn't it be set when mCx is created and never unset?

Most other code I've seen that set these sort of flags always unset them after compiling. I assume this is so other code trying to use this context don't unexpectedly get hit by flags they didn't set themselves.

Comment 3

[Jason Orendorff [:jorendorff]]

Comment on attachment 514589 [details] [diff] [review]
Use JSOPTION_NO_SCRIPT_RVAL in nsFrameMessageManager.cpp

I don't know what an nsFrameScriptExecutor is, but as far as JSAPI use is concerned, this patch is definitely good.

Comment 4

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/bde6b79dea6f