That bug changed TB value unit to MB from KB. "blocking-seamonkey2.1=?": As this impacts strings, SM should do it before 2.1b3, if we want to sync' (in 2.1 cycle).
> David :Bienvenu 2011-01-12 17:08:48 PST > Created attachment 503351 [details] [diff] [review] > turn on autocompact by default, switch to MB > > This patch does several things: > > Turn on autocompact by default > For TB, migrate the pref to MB, and migrate old pref > Fix the options UI to use the new pref in MB > switch the default to 20MB, if the user hasn't changed the threshold. > > This leaves SM using the old pref, but if they fix their preferences UI to use > MB's, we can turn on the backend code for them.
So they didn't turn on autocompact just yet, which is good (see below). I don't see any problem with porting the first (prefs/UI) part and removing the ifdefs, though. Karsten? The reason why I have a problem with autocompacting (and the reason why I turned it off for me eventually after I had it activated for quite some time) is that it seems to throw away the current view, leaving you with an empty thread pane (at least that's what I recall from memory using SM 2.0; I neither checked SM trunk nor Shredder yet). Actually that happens whenever you compact a folder you're currently viewing, but with autocompacting it happens out of the blue (for anyone who doesn't know that it's due to compacting that is, but that's probably the majority of users).
Will ask bienvenu for sr once we have an r+.
Assignee: nobody → jh
Status: NEW → ASSIGNED
Attachment #514808 - Flags: review?(mnyromyr)
Attachment #514808 - Flags: superreview?(bienvenu)
Comment on attachment 514808 [details] [diff] [review] patch [Checkin: comment 6] cool, thx for getting to this so promptly.
Attachment #514808 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 514808 [details] [diff] [review] patch [Checkin: comment 6] http://hg.mozilla.org/comm-central/rev/f64fe11636ed
Attachment #514808 - Attachment description: patch → patch [Checkin: comment 6]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3
(In reply to comment #3) > So they didn't turn on autocompact just yet, which is good (see below). Ftr, iiuc, they did turn autocompact (prompt) on with their (shared) second patch.
No longer blocks: TB2SM
You need to log in before you can comment on or make changes to this bug.