Closed Bug 636426 Opened 13 years ago Closed 13 years ago

Scrollbars are broken on trunk

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: vingtetun, Assigned: vingtetun)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
browser is defined twice in PanBegin and confuse the code that finally give up on a browser is undefined in PanBegin, removing the 'let browser = getBrowser()' call in PanEnd solve the conflict! (and do not regress anything since browser is well defined)
Attachment #514771 - Flags: review?(mark.finkle)
Comment on attachment 514771 [details] [diff] [review]
Patch

hard to believe this actually breaks code. I would expect the old code to work fine.

The clean up is good in any case.
Attachment #514771 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/d51ca6d7732a
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Android; Linux armv71; rv2.0b13pre) Gecko/20110317 Firefox/4.0b13pre Fennec/4.0b6pre
Device: Droid 2 
OS: Android 2.2

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b13pre) Gecko/20110317 Firefox/4.0b13pre Fennec/4.0b6pre
Device: Maemo N900
Status: RESOLVED → VERIFIED
bugspam
Assignee: nobody → 21
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: