Make enabling profilers actually --enable-profiling

RESOLVED FIXED in mozilla2.0

Status

()

Core
Build Config
P1
normal
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla2.0
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Patch coming up.
Blocks: 592923
Created attachment 514828 [details] [diff] [review]
Make sure --enable-shark actually enables profiling.
Attachment #514828 - Flags: review?(ted.mielczarek)
Whiteboard: [need review]
Attachment #514828 - Flags: review?(ted.mielczarek) → review+
Whiteboard: [need review] → [need approval]
Comment on attachment 514828 [details] [diff] [review]
Make sure --enable-shark actually enables profiling.

This should be very safe, and make our shark builds actually usable.
Attachment #514828 - Flags: approval2.0?
Attachment #514828 - Flags: approval2.0? → approval2.0+

Comment 3

7 years ago
I'd keep valgrind and callgrind together. Either move one up or leave the other where it is.
Oh, and the point is that the code that _checked_ MOZ_PROFILING used to come before the places that set it for the profilers.  The patch just fixes that.

Pushed as http://hg.mozilla.org/mozilla-central/rev/de0e9f27b608
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [need approval]
Target Milestone: --- → mozilla2.0
You need to log in before you can comment on or make changes to this bug.