Remove xul: prefixes in createElementNS calls in HUDService.jsm

RESOLVED FIXED in Firefox 8

Status

()

Firefox
Developer Tools
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: rc, Assigned: rc)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 8
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug] [cleanup] [console-1])

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
There are between 11 and 12 occurrences (depending on which patches are installed) of createElementNS(XUL_NS, "xul:tagname") in HUDService.jsm. The xul: prefix is at best a no-op since we're specifying the namespace. We should remove them based on Dao's comment in:

https://bugzilla.mozilla.org/show_bug.cgi?id=611795#c54

Updated

7 years ago
Whiteboard: [cleanup] → [cleanup] [console-1]

Updated

6 years ago
Whiteboard: [cleanup] [console-1] → [good first bug] [cleanup] [console-1]
(Assignee)

Comment 1

6 years ago
taking this as a follow-up to bug 662807.
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
(Assignee)

Comment 2

6 years ago
Created attachment 548537 [details] [diff] [review]
[in-fx-team] remove xul:
Attachment #548537 - Flags: review?(ddahl)

Comment 3

6 years ago
Comment on attachment 548537 [details] [diff] [review]
[in-fx-team] remove xul:

Awesome. More of my clutter is being removed!
Attachment #548537 - Flags: review?(ddahl) → review+
(Assignee)

Updated

6 years ago
Whiteboard: [good first bug] [cleanup] [console-1] → [good first bug] [cleanup] [console-1][fixed-in-devtools]
(Assignee)

Updated

6 years ago
Attachment #548537 - Attachment description: remove xul: → [in-fx-team] remove xul:
(Assignee)

Updated

6 years ago
Whiteboard: [good first bug] [cleanup] [console-1][fixed-in-devtools] → [good first bug] [cleanup] [console-1][fixed-in-fx-team]
http://hg.mozilla.org/mozilla-central/rev/a2690a2d6270
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [good first bug] [cleanup] [console-1][fixed-in-fx-team] → [good first bug] [cleanup] [console-1]
Target Milestone: --- → Firefox 8
You need to log in before you can comment on or make changes to this bug.