Block WebGL on Mac OS X 10.5 (not on 10.6)

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch block WebGL on 10.5 (obsolete) — Splinter Review
Comment added in the patch:

  // Many WebGL issues on 10.5, especially:
  //   * bug 631258: WebGL shader paints using textures belonging to other processes on Mac OS 10.5
  //   * bug 618848: Post process shaders and texture mapping crash OS X 10.5

On Tryserver for now.
Note that Chromium people confirmed they were having the same issues on 10.5 and agreed that blacklisting it was a reasonable option.
You can probably use nsToolkit::OnSnowLeopardOrLater() here.
Thanks!
New tryserver run (previous one failed anyway):
http://tbpl.mozilla.org/?tree=MozillaTry&rev=dd879d8ba8d0
Attachment #514949 - Attachment is obsolete: true
Comment on attachment 515079 [details] [diff] [review]
block WebGL on 10.5 (updated)

Green on tryserver! Asking for review+approval.
Attachment #515079 - Flags: review?(jmuizelaar)
Attachment #515079 - Flags: approval2.0?
Comment on attachment 515079 [details] [diff] [review]
block WebGL on 10.5 (updated)

r+ before a? please!
Attachment #515079 - Flags: approval2.0?
Comment on attachment 515079 [details] [diff] [review]
block WebGL on 10.5 (updated)

I guess we can take this. Hopefully, we can take it out in FF5
Attachment #515079 - Flags: review?(jmuizelaar) → review+
Attachment #515079 - Flags: approval2.0+
Assignee: nobody → bjacob
http://hg.mozilla.org/mozilla-central/rev/24cff06ec75f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
10.5 user cannot use WebGL on Firefox 4 (Beta 13?) RC/final ?
Correct, though there will be no beta 13.
And, people who know they want WebGL can still force-enable (webgl.force-enabled=true)
You need to log in before you can comment on or make changes to this bug.