636695 - Make --enable-debug-symbols on by default

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

There's virtually no downside to having debug symbols for a build, and people almost always want them if they're doing their own build, so we should just enable them by default. We'll still allow disabling them for edge cases, and we'll still allow --enable-debug-symbols="-compiler-options".

Comment 1

[Mitchell Field [:Mitch]]

Attachment: Patch

This also removes the deprecated --enable-debugger-info-modules option, which raised a warning and only set --enable-debug-symbols anyway.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 515071 [details] [diff] [review]
Patch

># HG changeset patch
># Parent 143c8e9082afef42caf66f7916e9bef0fd720cf3
># User Mitchell Field <[e-mail]>
>Bug 636695 - Make --enable-debug-symbols on by default.
>
>diff --git a/configure.in b/configure.in
>--- a/configure.in
>+++ b/configure.in
>-dnl ========================================================
> dnl = Enable generation of debug symbols
> dnl ========================================================
> MOZ_ARG_ENABLE_STRING(debug-symbols,
> [  --enable-debug-symbols[=DBG]
>                           Enable debugging symbols (using compiler flags DBG)],

I was wondering if we should make this MOZ_ARG_DISABLE, but I guess it's all the same, and people are more likely to use --enable-debug-symbols=foo than --disable.

Comment 3

[Mike Hommey [:glandium]]

This patch has a downside: --enable-debug-symbols is not passed down to nsprpub's configure.

Comment 4

[(not currently active) Ted Mielczarek]

Hrm. Good point. We should fix that.

Comment 5

[Mitchell Field [:Mitch]]

Comment on attachment 515071 [details] [diff] [review]
Patch

> if test -n "$MOZ_DEBUG" -o -n "$MOZ_DEBUG_SYMBOLS"; then
>     AC_DEFINE(MOZ_DEBUG_SYMBOLS)
>     export MOZ_DEBUG_SYMBOLS
> fi

It's exported for nsprpub/configure and resulted in PDBs in objdir/nsprpub here.

I'd pushed it already:
http://hg.mozilla.org/projects/build-system/rev/f00d8a38ac19

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/f00d8a38ac19