Closed Bug 636701 Opened 13 years ago Closed 13 years ago

Please change mozconfig files for ARM targets to include *FLAGS

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Platform:
ARM
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: glandium, Unassigned)

References

Details

Attachments

(1 file)

Add C/CXX/ASFLAGS for mobile
8.01 KB, patch
bhearsum
: feedback+
Details | Diff | Splinter Review 
With bug 626035, we're going to let the default build pick whatever the toolchain uses and leave it to users to provide the *FLAGS they want.

This means that the things that are currently customized for Android and Maemo in configure.in need to be set in mozconfigs instead.
This is Core: Build Config since it's Makefile oriented, I believe. RelEng only manages the official mozconfigs (located in http://hg.mozilla.org/build/buildbot-configs).
Assignee: server-ops-releng → nobody
Component: Server Operations: RelEng → Build Config
Product: mozilla.org → Core
QA Contact: zandr → build-config
Version: other → Trunk
That's exactly what it is about.
Assignee: nobody → server-ops-releng
Component: Build Config → Server Operations: RelEng
Product: Core → mozilla.org
QA Contact: build-config → zandr
Version: Trunk → other
This should match the current behaviour.

The interesting part is that the comment in android-nothumb's mozconfig says "Produce ARMv5 builds", while the build is actually targetted at armv7 thanks to configure. The patch changes nothing about that, but you might want to change the -march= there. This is another demonstration that these flags really are best set in mozconfig.
Attachment #516550 - Flags: review?(bhearsum)
Mark would probably know for comment 3.
Server Ops: Releng != Release Engineering

This is not Server Operations.
Assignee: server-ops-releng → nobody
Component: Server Operations: RelEng → Release Engineering
QA Contact: zandr → release
Comment on attachment 516550 [details] [diff] [review]
Add C/CXX/ASFLAGS for mobile

I'm going to guess we also have to update the mozconfigs under mobile-tryserver/ .
(In reply to comment #6)
> Comment on attachment 516550 [details] [diff] [review]
> Add C/CXX/ASFLAGS for mobile
> 
> I'm going to guess we also have to update the mozconfigs under
> mobile-tryserver/ .

Ah yes, I didn't see those.
Comment on attachment 516550 [details] [diff] [review]
Add C/CXX/ASFLAGS for mobile

I'm not really capable of reviewing this. You're modifying the correct mozconfigs, but I don't know anything about the specific flags.
Attachment #516550 - Flags: review?(bhearsum) → feedback+
Per IRC, blassey doesn't want this.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: