Closed
Bug 636703
Opened 13 years ago
Closed 13 years ago
Get rid of DECLARE_NATIVE_ERROR_CLASS
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
RESOLVED
FIXED
Q1 12 - Brannan
People
(Reporter: lhansen, Assigned: lhansen)
References
Details
(Whiteboard: has-patch)
Attachments
(1 file)
|
12.39 KB,
patch
|
stejohns
:
review+
|
Details | Diff | Splinter Review |
As the glue gets simpler and simpler this macro pays for itself less and less. We should just expand the class definitions, this will confuse both readers and tools less. If bug #636517 lands there will be almost nothing left of the macros and it's time to do it.
|
Assignee | |
Comment 1•13 years ago
|
||
Expands the macro, sorts classes alphabetically. So far as I could find out, the macro is not used anywhere in the Flash Player sources.
Attachment #515311 -
Flags: review?(stejohns)
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: has-patch
|
||
Comment 2•13 years ago
|
||
Comment on attachment 515311 [details] [diff] [review] Patch Note that the existing inheritance of the Classes is wrong; all Classes should inherit directly from ClassClosure, not from NativeErrorClass. But that's probably a separate bug.
Attachment #515311 -
Flags: review?(stejohns) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
(In reply to comment #2) > Comment on attachment 515311 [details] [diff] [review] > Patch > > Note that the existing inheritance of the Classes is wrong; all Classes should > inherit directly from ClassClosure, not from NativeErrorClass. But that's > probably a separate bug. I was wondering about that. But I'll leave that for a separate pass.
|
|
Assignee | |
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 4•13 years ago
|
||
changeset: 6000:c4f906f9197e user: Lars T Hansen <lhansen@adobe.com> summary: Fix 636703 - Get rid of DECLARE_NATIVE_ERROR_CLASS (r=stejohns) http://hg.mozilla.org/tamarin-redux/rev/c4f906f9197e
You need to log in
before you can comment on or make changes to this bug.
Description
•