636707 - [Mac] Firefox 4.0b13pre crash [@ mozilla::layers::ImageLayerOGL::RenderLayer ]

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[d.a.]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b13pre) Gecko/20110224 Firefox/4.0b13pre
Build Identifier: 

I got this crash after watching a 720p video on YouTube in fullscreen, and going to a new video.

STR:
1. Load up a few videos in the video queue, may need to have an 720p video among them.
2. Set the player to view the 720p version of the video.
3. Go to fullscreen and watch the video.
4. Exit full screen.
5. Go to the next video in the queue.

Firefox should now crash.

Crash reports:
https://crash-stats.mozilla.com/report/index/bp-0c83142a-5207-4ad0-ba8d-88da82110225
https://crash-stats.mozilla.com/report/index/bp-2792304a-4766-4d02-9120-a3fb72110224

Reproducible: Always

Comment 1

[Marcia Knous [:marcia]]

Haven't yet been able to reproduce your crash usingMozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b13pre) Gecko/20110225 Firefox/4.0b13pre. Are there any other steps you are doing between steps 4 and 5?

Comment 2

[d.a.]

No extra step between step 4 and 5, but on both occasions Firefox had been used for a while (more than 30 minutes). I think there must be something must happen before step 1 for the crash to happen.

Comment 3

[Scoobidiver (away)]

It is #15 top crasher on Mac OS X in 4.0b12.

Here are some comments:
"Was using Command+- to reduce the side of a page which contained a Flash video."
"crashed closing a tab with quicktime player streaming an mp3 in it"
"crash appeared during debugging session of adobe flex application."
"Reading reddit, just installed reddit enhancement suite, the greasemonkey script, which made firefox a bit laggy, and I was just scrolling down when it crashed."
"I was just randomly surfing the web, I clicked on Adium to answer an IM and firefox just straight up crashed."

More reports at:
https://crash-stats.mozilla.com/report/list?product=Firefox&range_value=4&range_unit=weeks&signature=mozilla%3A%3Alayers%3A%3AImageLayerOGL%3A%3ARenderLayer

Comment 4

[Scoobidiver (away)]

It is #7 top crasher on Mac OS X in 4.0RC1.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

happened to me without full-screen

Comment 6

[Marcia Knous [:marcia]]

Crashed in this stack while trying to reproduce Bug 637367.

Comment 7

[Joe Drew (not getting mail)]

I just got this crash while trying to download an mp3 (I presume into the QuickTime plugin). bp-adda619d-d07d-4abe-8bed-e34042110429

Comment 8

[Marcia Knous [:marcia]]

I crashed in this stack while I was not using the browser running 4.0.1. Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:2.0.1) Gecko/20100101 Firefox/4.0.1

Comment 9

[Marcia Knous [:marcia]]

http://tinyurl.com/3ccazon indicates 512 crashes in the last week across all versions. Many of the crash comments do specifically mention flash. One of the tabs I had open at the time of the crash was hulu.com.

Comment 10

[Josh Aas]

Benoit - can you take a look at this?

Comment 11

[Benoit Girard (:BenWa)]

I though it might be related to bug 641227 but this problem was reported before.

Still investigating.

Comment 12

[Benoit Girard (:BenWa)]

Attachment: Check for null MacIOSurfaceImageOGL. v1

Comment 13

[Benoit Girard (:BenWa)]

Comment on attachment 543763 [details] [diff] [review]
Check for null MacIOSurfaceImageOGL. v1

Null Pointer check will fix a top crashers, we should land this on aurora/beta.

Comment 14

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/c97d7a25a921

Comment 15

[Benoit Girard (:BenWa)]

The patch is already on aurora because it landed before the merge, checkin needed for beta.

Comment 16

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-beta/rev/7e4bc2255cfb

Comment 17

[AndreiD[QA]]

Verified fixed on:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0) Gecko/20100101 Firefox/6.0

There is no error / crash while playing highres videos from a youtube playlist, toggling fullscreen and normal window.