63672 - JS strict warnings execute onerror handlers...

Status: VERIFIED DUPLICATE of bug 220603

(Core :: DOM: Core & HTML, defect, P2)

Description

[Johnny Stenback (:jst)]

Even if a page contains JS strict warnings the onerror handler should not be
called. onerror is for *errors*, not for warnings.

Comment 1

[Johnny Stenback (:jst)]

This patch makes mozilla not call the onerror handler for JS strict warnings:

Index: dom/src/base/nsJSEnvironment.cpp
===================================================================
RCS file: /cvsroot/mozilla/dom/src/base/nsJSEnvironment.cpp,v
retrieving revision 1.122
diff -u -r1.122 nsJSEnvironment.cpp
--- nsJSEnvironment.cpp 2000/12/07 02:08:21     1.122
+++ nsJSEnvironment.cpp 2000/12/25 00:20:39
@@ -96,7 +96,7 @@
       //send error event first, then proceed
       nsCOMPtr<nsIDocShell> docShell;
       globalObject->GetDocShell(getter_AddRefs(docShell));
-      if (docShell) {
+      if (docShell && !JSREPORT_IS_STRICT(report->flags)) {
         static PRInt32 errorDepth = 0; // Recursion prevention
         errorDepth++;

Comment 2

[Johnny Stenback (:jst)]

Ok, turns out this is an invalid bug, if you want JS warnings to be treated as
errors then they will call the onerror handler.

Comment 3

[Prashant Desale]

Invalid

Comment 4

[Johnny Stenback (:jst)]

*** Bug 118464 has been marked as a duplicate of this bug. ***

Comment 5

[Johnny Stenback (:jst)]

*** Bug 118464 has been marked as a duplicate of this bug. ***

Comment 6

[Boris Zbarsky [:bzbarsky]]

*** Bug 137519 has been marked as a duplicate of this bug. ***

Comment 7

[Vladimir Ermakov]

*** Bug 137519 has been marked as a duplicate of this bug. ***

Comment 8

[Boris Zbarsky [:bzbarsky]]

Reopening.  This was reconsidered and fixed, recently.

Comment 9

[Boris Zbarsky [:bzbarsky]]

*** This bug has been marked as a duplicate of 220603 ***

Comment 10

[Boris Zbarsky [:bzbarsky]]

*** Bug 118464 has been marked as a duplicate of this bug. ***

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

verified.