636735 - Make bug count line optional

Status: RESOLVED FIXED

(Tree Management Graveyard :: OrangeFactor, defect)

Description

[Mark Côté [:mcote]]

In retrospect, the graphs with multiple lines are pretty crowded.  As was
mentioned before, we should probably make the bug count line optional, since
it conveys similar, but probably less useful information.

That said, perhaps we should optionally show the number of test runs.  Perhaps
two graphs: orange frequency with moving average, and bug count with test run
count.  This would help solve bug 636733.

Even *better* would be a very simple, generic way to turn on and off lines
in flot graphs, perhaps by clicking on the legend.

Comment 1

[Mark Côté [:mcote]]

Attachment: Add test run count to OF and Bug Details; make graphs hideable; hide orange and test-run count by default

Okay I whipped up a plugin for flot to add links to the graph labels that allow the user to hide (and show) the various lines.  I'll probably package this up separately at some point.

I added test run count to the graphs on the Orange Factor and Bug Details views but made it and orange count hidden by default.

Also moved the rounding of the graphed numbers from the showLineGraphMultiple() to calculateMetric() so that the former function is more agnostic about the data coming in.

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 515787 [details] [diff] [review]
Add test run count to OF and Bug Details; make graphs hideable; hide orange and test-run count by default

Great patch!  Love the hideable lines.

I found the y-axis label "orange / test run count" slightly confusing at first; I kept contrasting this to the other y-axis label, "orange count per test run", and saw it as "oranges \ test run count", which is really the same.  Maybe just "count", or "orange, test run count"?  I dunno.

This also exposes an issue with one of our REST API's.  bybug doesn't return any data for dates on which the bug didn't occur, if you pass a bug to it.  So for bug details graphs, the test run count shows as 0 for dates on which the bug wasn't observed, which is obviously wrong.  See e.g., http://localhost:8080/?display=Bug&bugid=633566&startday=2011-02-01&endday=2011-02-23#

There are multiple possible ways to fix this; one would be to change the bybug API to include testrun data and an orangecount of 0 for dates on which the bug doesn't exist; I'm not sure if this would have any effects on other code.  I'm ok if you want to file a bug for that and we can deal with it separately.

Comment 3

[Mark Côté [:mcote]]

Yeah, I think your proposed solution is the right one; otherwise, we'd just have to make an extra call.  I'll file a separate bug.

Changed 'oranges / test run count' to 'oranges, test run count' as you suggested.

http://hg.mozilla.org/automation/orangefactor/rev/82ab89e14477