Closed Bug 636828 Opened 11 years ago Closed 11 years ago

browser.js nsINavBookmarkObserver::onItemAdded incorrectly expects aURI when folder added

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 4.0

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(2 files)

Attached file Log of error output.
When Sync creates a livemark (or even other items, I think), the attached gets dumped into the console. Patch to follow.
Suggested fix.
Attachment #515168 - Flags: review?(mak77)
Comment on attachment 515168 [details] [diff] [review]
Proposed patch. v1

Thanks!

Asking approval for a safe null check that removes useless churn from the Error Console.
Attachment #515168 - Flags: review?(mak77)
Attachment #515168 - Flags: review+
Attachment #515168 - Flags: approval2.0?
Whiteboard: [has patch][has review][needs approval2.0]
Attachment #515168 - Flags: approval2.0? → approval2.0+
Away she goes:

https://hg.mozilla.org/services/services-central/rev/a0cd97a42315
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Whiteboard: [has patch][has review][needs approval2.0] → [has patch][has review][fixed in services-central]
mak mentioned that he might want to land this on m-c before s-c gets merged, just in case the merge doesn't happen before code freeze.

Rock on, mak; johnath approved for landing on m-c, not just s-c.
Whiteboard: [has patch][has review][fixed in services-central] → [has patch][has review][fixed in services]
Merged to m-c: http://hg.mozilla.org/mozilla-central/rev/a0cd97a42315
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review][fixed in services]
Target Milestone: --- → Firefox 4.0
You need to log in before you can comment on or make changes to this bug.