Closed
Bug 636828
Opened 13 years ago
Closed 13 years ago
browser.js nsINavBookmarkObserver::onItemAdded incorrectly expects aURI when folder added
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 4.0
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
Attachments
(2 files)
|
2.25 KB,
text/plain
|
Details | |
|
844 bytes,
patch
|
mak
:
review+
johnath
:
approval2.0+
|
Details | Diff | Splinter Review |
When Sync creates a livemark (or even other items, I think), the attached gets dumped into the console. Patch to follow.
|
||
Comment 2•13 years ago
|
||
Comment on attachment 515168 [details] [diff] [review] Proposed patch. v1 Thanks! Asking approval for a safe null check that removes useless churn from the Error Console.
Attachment #515168 -
Flags: review?(mak77)
Attachment #515168 -
Flags: review+
Attachment #515168 -
Flags: approval2.0?
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [has patch][has review][needs approval2.0]
|
||
Updated•13 years ago
|
Attachment #515168 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Away she goes: https://hg.mozilla.org/services/services-central/rev/a0cd97a42315
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Whiteboard: [has patch][has review][needs approval2.0] → [has patch][has review][fixed in services-central]
|
|
Assignee | |
Comment 4•13 years ago
|
||
mak mentioned that he might want to land this on m-c before s-c gets merged, just in case the merge doesn't happen before code freeze. Rock on, mak; johnath approved for landing on m-c, not just s-c.
Whiteboard: [has patch][has review][fixed in services-central] → [has patch][has review][fixed in services]
|
||
Comment 5•13 years ago
|
||
Merged to m-c: http://hg.mozilla.org/mozilla-central/rev/a0cd97a42315
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review][fixed in services]
|
||
Updated•13 years ago
|
Target Milestone: --- → Firefox 4.0
You need to log in
before you can comment on or make changes to this bug.
Description
•