636872 - allow CSS style cursor property to be used for plugins

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Comment 1

[Josh Aas]

Attachment: utility code v1.0

This code seems to modify the DOM properly from a plugin but the cursor doesn't change.

Comment 2

[Josh Aas]

Attachment: modify border sample v1.0

This sample code from Google's Chromium project succeeds in modifying the border of the plugin using the technique I want to use to modify the cursor.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Do you see CSS parse errors in the error console?

Comment 4

[Josh Aas]

I don't see any errors.

Comment 5

[Josh Aas]

Giving a plugin a basic style attribute setting the cursor (style="cursor: crosshair;") doesn't work either. So this is probably not about whether or not it is done from plugins.

Comment 6

[Josh Aas]

Chrome has the same behavior we do - setting the cursor style on a plugin has no impact no matter how you do it.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Oh, you're setting this on the <object> or <embed> that loaded the plug-in?

Then yeah, sounds like something else is messing with the cursor....

Comment 8

[Boris Zbarsky [:bzbarsky]]

nsObjectFrame::GetCursor returns NS_ERROR_NOT_IMPLEMENTED, which causes nsEventStateManager::UpdateCursor to bail out.

Looks like that was done to fix bug 118877.

Comment 9

[Josh Aas]

I've started working on a spec for allowing this to work:

https://wiki.mozilla.org/NPAPI:DOMCursors

I have it working in Gecko and a test plugin. If we don't allow this we're going to be stuck with native API forwarding for cursors.

Comment 10

[Josh Aas]

Attachment: fix v1.0

This fully implements DOM cursor control for plugins according to the current proposal, OOP and IP.

Comment 11

[Josh Aas]

Comment on attachment 522458 [details] [diff] [review]
fix v1.0

The spec is not quite approved but it's close and this patch is ready for review.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 522458 [details] [diff] [review]
fix v1.0

r=me

This doesn't implement the "let the plugin set the cursor" bit, right?

Do we have a way to test this?

Comment 13

[Josh Aas]

(In reply to comment #12)
> This doesn't implement the "let the plugin set the cursor" bit, right?

Not sure what you mean. This patch is all that is necessary for the plugin to set the cursor via the CSS cursor property via NPRuntime. Plugins can already do that actually, it just doesn't actually cause the cursor to change because the object frame returns NS_ERROR_FAILURE for nsObjectFrame::GetCursor regardless of what the CSS cursor property says. With this patch that call can succeed (via the parent implementation), allowing the CSS-specified cursor to be displayed.

Comment 14

[Boris Zbarsky [:bzbarsky]]

Ah, I see.  OK.

Comment 15

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/b59f443dd42f