637040 - iframe embedding youtube not displaying in os x

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Dave Herman [:dherman]]

I updated to the latest nightly and tried again, but the embedded video at this page is still not displaying:

http://blog.fishbone.net/everyday-sunshine-the-story-of-fishbone-offic

It starts playing but there's no video. I'm on a MB Pro, OS X 10.6.6.

When I go to the actual YouTube link the video plays fine.

Dave

Comment 1

[Matthias Versen [:Matti]]

The product "Firefox" is basically only the Userinterface of the browser. A problem with the content of a website is in most cases the product "Core".

wfm with Seamonkey trunk on win32, OS X only ?

Comment 2

[Dave Herman [:dherman]]

> The product "Firefox" is basically only the Userinterface of the browser. A
> problem with the content of a website is in most cases the product "Core".

My bad -- still learning the products and components.

> wfm with Seamonkey trunk on win32, OS X only ?

I only have a Mac available to me right now, so I can't try it out elsewhere. Just to make sure, I reinstalled Flash and the site is still not working. It is working in other browsers, so it's not a bug in the site, or at least not an obvious one.

Dave

Comment 3

[Boris Zbarsky [:bzbarsky]]

I can reproduce this on Mac.  The problem goes away if I disable GL acceleration.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Minimalish testcase

The text is needed.  The bug also reproduces if I wrap a <div> around the text, as in the original site, but just using a fixed-height <div> does NOT show the bug.

The background image is arbitrary; it being fixed is required, though.

Comment 5

[Boris Zbarsky [:bzbarsky]]

And this is a somewhat recent regression.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Regression range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2c646d10b9c7&tochange=b4aa47ca42c1

Matt has some GL changes in that range.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

This is WFM on OSX, latest nightly. Boris: can you still reproduce?

Comment 8

[Joe Drew (not getting mail)]

In order to reproduce you have to be not in the YouTube HTML5 beta.

Comment 9

[Boris Zbarsky [:bzbarsky]]

And you have to have GL acceleration actually enabled.

And yes, I can reproduce on today's nightly.

Comment 10

[Matt Woodrow (:mattwoodrow)]

Attachment: Reset the active texture

Thanks for the testcase bz! (especially noticing that the fixed background caused it).

Thebes layers with component alpha were changing the active texture to GL_TEXTURE1 and never resetting it.

This makes us explicitly bind the texture we want for MacIOSurfaceImages and reset it in ThebesLayer. We don't really need both, but I don't see the harm.

Comment 11

[(no longer active)]

Comment on attachment 515777 [details] [diff] [review]
Reset the active texture

Can this be tested automatically using the test plugin, and perhaps a white background image?

Comment 12

[Matt Woodrow (:mattwoodrow)]

Our test plugin doesn't use core animation and wouldn't hit this bug sadly. That may be an issue in it's own right.

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 515777 [details] [diff] [review]
Reset the active texture

no-brainer

Comment 14

[Matt Woodrow (:mattwoodrow)]

http://hg.mozilla.org/mozilla-central/rev/65c1d9309c57

Comment 15

[Alex Lakatos[:AlexLakatos]]

Verified on Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0) Gecko/20100101 Firefox/4.0