Closed
Bug 637049
Opened 13 years ago
Closed 13 years ago
No GUI to return from fullscreen mode with popups
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 6
Tracking | Status | |
---|---|---|
blocking2.0 | --- | - |
People
(Reporter: c.ascheberg, Assigned: c.ascheberg)
References
()
Details
(Keywords: regression)
Attachments
(1 file)
1.81 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows NT 6.0; rv:2.0b13pre) Gecko/20110226 Firefox/4.0b13pre Build Identifier: Mozilla/5.0 (Windows NT 6.0; rv:2.0b13pre) Gecko/20110226 Firefox/4.0b13pre When opening 'toolbar=0' popup in fullscreen mode, caption buttons will not be displayed in the GUI anymore Reproducible: Always Steps to Reproduce: 1. open URL above 2. click link 3. in popup: click Minefield-Button > Fullscreen (or press F11) 4. move mouse to top of the screen Actual Results: only urlbar will be shown, no caption buttons Expected Results: caption buttons should be displayed also, as people might not know the keyboard shortcuts
Assignee | ||
Comment 1•13 years ago
|
||
only happens with tabs-on-top
Comment 2•13 years ago
|
||
same issue as bug 615522 I suspect. pretty darned sure this isn't going to block the release.
Comment 3•13 years ago
|
||
We can fix this in a security/stability release, not severe enough to hold back Firefox 4. Would definitely consider a safe patch if it materializes before Fx4 ships though.
blocking2.0: ? → -
Assignee | ||
Comment 4•13 years ago
|
||
In these cases the window controls can / should be displayed in the tab bar: 1.: document.documentElement.getAttribute("chromehidden").indexOf("toolbar") == -1 -> check that it is *not* a javascript popup with 'toolbar=0', where the tab bar is hidden 2.: navbar.collapsed -> user chose option to hide navbar (should fix bug 615522), so use tab bar 3.: TabsOnTop.enabled -> as before: use tab bar when tabs-on-top, check that tab bar does not autohide (I think ideally it should not only check for the pref, but if nav-bar is actually hidden (collapsed), but that would have to be updated whenever a tab is opened or closed) There is still no check if there is at least the tab bar or the url bar visible at all.
Assignee | ||
Updated•13 years ago
|
Attachment #515509 -
Flags: review?(dao)
Assignee | ||
Comment 5•13 years ago
|
||
can somebody at least confirm this bug and maybe even look at the few lines short patch?
Updated•13 years ago
|
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
Updated•13 years ago
|
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: DUPLICATE → ---
Comment 9•13 years ago
|
||
Comment on attachment 515509 [details] [diff] [review] patch >+ var navbar = document.getElementById("nav-bar"); >+ var ctlsOnTabbar = document.documentElement.getAttribute("chromehidden") >+ .indexOf("toolbar") == -1 && This should be replaced with window.toolbar.visible. > if (fullscreenctls.parentNode.id == "nav-bar" && ctlsOnTabbar) { Now that you have the navbar reference, you could compare it directly with fullscreenctls.parentNode. Looks good otherwise, thanks!
Attachment #515509 -
Flags: review?(dao) → review+
Comment 10•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/2e7f1fb3ce4c (I made the two changes from comment 9.)
Assignee: nobody → c.ascheberg
Status: NEW → RESOLVED
Closed: 13 years ago → 13 years ago
OS: Windows Vista → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
Assignee | ||
Comment 11•13 years ago
|
||
(In reply to comment #10) > http://hg.mozilla.org/mozilla-central/rev/2e7f1fb3ce4c > > (I made the two changes from comment 9.) Thank you!
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•