Last Comment Bug 637088 - InsertPopup in classic theme is missing icons for menuitems
: InsertPopup in classic theme is missing icons for menuitems
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Themes (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b3
Assigned To: Ian Neal
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-26 17:33 PST by Ian Neal
Modified: 2011-02-27 15:30 PST (History)
0 users
iann_bugzilla: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Correct insertpopup menuitems patch (3.87 KB, patch)
2011-02-26 17:33 PST, Ian Neal
neil: review+
stefanh: ui‑review+
Details | Diff | Review
Correct insertpopup menuitems patch v1.1 [Checked in: Comment 3] (4.17 KB, patch)
2011-02-27 15:29 PST, Ian Neal
iann_bugzilla: review+
iann_bugzilla: superreview+
Details | Diff | Review

Description Ian Neal 2011-02-26 17:33:37 PST
Created attachment 515411 [details] [diff] [review]
Correct insertpopup menuitems patch

In Classic themes's editorFormatToolbar.css the file it references for the menuitem icons (chrome://editor/skin/icons/btn1.gif) does not exist.
To see the issue, with the Classic theme, go into a mail compose window and click on the drop down for "Insert a Link, Anchor, Image, Horizontal Line, or Table" and none of the menuitems have an image. Compare against the same drop down in Modern theme.
Comment 1 neil@parkwaycc.co.uk 2011-02-27 03:23:50 PST
Comment on attachment 515411 [details] [diff] [review]
Correct insertpopup menuitems patch

I guess that menu doesn't get used a lot :-(
Comment 2 Stefan [:stefanh] 2011-02-27 05:34:05 PST
Comment on attachment 515411 [details] [diff] [review]
Correct insertpopup menuitems patch

diff --git a/suite/themes/classic/mac/editor/editorFormatToolbar.css b/suite/themes/classic/mac/editor/editorFormatToolbar.css
--- a/suite/themes/classic/mac/editor/editorFormatToolbar.css
+++ b/suite/themes/classic/mac/editor/editorFormatToolbar.css
@@ -388,57 +388,57 @@ toolbarbutton.chromeclass-toolbar-additi
 
 #AlignJustifyItem:hover {
   -moz-image-region: rect(130px 32px 146px 16px);
 }
 
 /* ..... insert menu ..... */
 
 #InsertPopup > menuitem {
-  list-style-image: url("chrome://editor/skin/icons/btn1.gif");
+  list-style-image: url("chrome://editor/skin/icons/editoricons-small.png");
 }
 
 #InsertLinkItem {
-  -moz-image-region: rect(16px 16px 32px 0);
+  -moz-image-region: rect(60px 19px 79px 0);
 }
 
 #InsertLinkItem:hover {
-  -moz-image-region: rect(16px 32px 32px 16px);
+  -moz-image-region: rect(60px 39px 79px 20px);
 }

I must confess that I don't think I've ever used these menus... Would you mind removing the :hover rules from both menus (insert and align)? We don't do this on Mac (it also look funny in the align menu since the menuitem hover background is blue) and afaics this is the only remnant left from an erlier era.
Comment 3 Ian Neal 2011-02-27 15:29:42 PST
Created attachment 515529 [details] [diff] [review]
Correct insertpopup menuitems patch v1.1 [Checked in: Comment 3]

As checked in.

http://hg.mozilla.org/comm-central/rev/420c4a5b35a5

Note You need to log in before you can comment on or make changes to this bug.