InsertPopup in classic theme is missing icons for menuitems

RESOLVED FIXED in seamonkey2.1b3

Status

SeaMonkey
Themes
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
seamonkey2.1b3
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 515411 [details] [diff] [review]
Correct insertpopup menuitems patch

In Classic themes's editorFormatToolbar.css the file it references for the menuitem icons (chrome://editor/skin/icons/btn1.gif) does not exist.
To see the issue, with the Classic theme, go into a mail compose window and click on the drop down for "Insert a Link, Anchor, Image, Horizontal Line, or Table" and none of the menuitems have an image. Compare against the same drop down in Modern theme.
Attachment #515411 - Flags: review?(neil)
(Assignee)

Updated

7 years ago
Attachment #515411 - Flags: ui-review?(stefanh)

Comment 1

7 years ago
Comment on attachment 515411 [details] [diff] [review]
Correct insertpopup menuitems patch

I guess that menu doesn't get used a lot :-(
Attachment #515411 - Flags: review?(neil) → review+

Comment 2

7 years ago
Comment on attachment 515411 [details] [diff] [review]
Correct insertpopup menuitems patch

diff --git a/suite/themes/classic/mac/editor/editorFormatToolbar.css b/suite/themes/classic/mac/editor/editorFormatToolbar.css
--- a/suite/themes/classic/mac/editor/editorFormatToolbar.css
+++ b/suite/themes/classic/mac/editor/editorFormatToolbar.css
@@ -388,57 +388,57 @@ toolbarbutton.chromeclass-toolbar-additi
 
 #AlignJustifyItem:hover {
   -moz-image-region: rect(130px 32px 146px 16px);
 }
 
 /* ..... insert menu ..... */
 
 #InsertPopup > menuitem {
-  list-style-image: url("chrome://editor/skin/icons/btn1.gif");
+  list-style-image: url("chrome://editor/skin/icons/editoricons-small.png");
 }
 
 #InsertLinkItem {
-  -moz-image-region: rect(16px 16px 32px 0);
+  -moz-image-region: rect(60px 19px 79px 0);
 }
 
 #InsertLinkItem:hover {
-  -moz-image-region: rect(16px 32px 32px 16px);
+  -moz-image-region: rect(60px 39px 79px 20px);
 }

I must confess that I don't think I've ever used these menus... Would you mind removing the :hover rules from both menus (insert and align)? We don't do this on Mac (it also look funny in the align menu since the menuitem hover background is blue) and afaics this is the only remnant left from an erlier era.
Attachment #515411 - Flags: ui-review?(stefanh) → ui-review+
(Assignee)

Comment 3

7 years ago
Created attachment 515529 [details] [diff] [review]
Correct insertpopup menuitems patch v1.1 [Checked in: Comment 3]

As checked in.

http://hg.mozilla.org/comm-central/rev/420c4a5b35a5
Attachment #515411 - Attachment is obsolete: true
Attachment #515529 - Flags: superreview+
Attachment #515529 - Flags: review+
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3
You need to log in before you can comment on or make changes to this bug.