637178 - Unused variable warning in GetContentMap

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Benjamin Stover (:stechz)]

First, I definitely appreciate cleaning up warnings in the optimized builds! Thanks for taking the time.

However, I'm worried that there a lot of places equivalent to this, and this solution is not as readable. Perhaps there is a more elegant solution? Chris, do you have any patterns for this kind of thing?

Comment 2

[Josh Matthews [:jdm]]

Blassey, see the decisions at the bottom of bug 577899.  It looks like people generally use ifdefs everywhere for this situation.

Comment 3

[Benjamin Stover (:stechz)]

Comment on attachment 515488 [details] [diff] [review]
Patch v1

(In reply to comment #2)
> Blassey, see the decisions at the bottom of bug 577899.  It looks like people
> generally use ifdefs everywhere for this situation.

Blassey?

Thanks for the link. I'm happy if this is the norm, but please indent the Init() call.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I've got an idea.  I'll head to bug 577899.

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/962e067eaa13