Closed Bug 637178 Opened 10 years ago Closed 10 years ago

Unused variable warning in GetContentMap

Categories

(Core :: Layout, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

Attached patch Patch v1Splinter Review
No description provided.
Attachment #515488 - Flags: review?(ben)
Flags: in-testsuite-
First, I definitely appreciate cleaning up warnings in the optimized builds! Thanks for taking the time.

However, I'm worried that there a lot of places equivalent to this, and this solution is not as readable. Perhaps there is a more elegant solution? Chris, do you have any patterns for this kind of thing?
Blassey, see the decisions at the bottom of bug 577899.  It looks like people generally use ifdefs everywhere for this situation.
Comment on attachment 515488 [details] [diff] [review]
Patch v1

(In reply to comment #2)
> Blassey, see the decisions at the bottom of bug 577899.  It looks like people
> generally use ifdefs everywhere for this situation.

Blassey?

Thanks for the link. I'm happy if this is the norm, but please indent the Init() call.
Attachment #515488 - Flags: review?(ben) → review+
I've got an idea.  I'll head to bug 577899.
Attachment #515488 - Flags: approval2.0?
Whiteboard: [build_warning][needs review] → [build_warning][needs approval]
Attachment #515488 - Flags: approval2.0? → approval2.0-
Depends on: post2.0
Whiteboard: [build_warning][needs approval] → [build_warning]
http://hg.mozilla.org/mozilla-central/rev/962e067eaa13
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.